Switch to Babel 7 #3522
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,134 +6,113 @@ | |
| */ | ||
| 'use strict'; | ||
|
|
||
| module.exports = function(api, opts) { | ||
| if (!opts) { | ||
| opts = {}; | ||
| } | ||
|
|
||
| // This is similar to how `env` works in Babel: | ||
| // https://babeljs.io/docs/usage/babelrc/#env-option | ||
| // We are not using `env` because it’s ignored in versions > [email protected]: | ||
| // https://github.com/babel/babel/issues/4539 | ||
| // https://github.com/facebookincubator/create-react-app/issues/720 | ||
| // It’s also nice that we can enforce `NODE_ENV` being specified. | ||
| var env = process.env.BABEL_ENV || process.env.NODE_ENV; | ||
| var isEnvDevelopment = env === 'development'; | ||
| var isEnvProduction = env === 'production'; | ||
| var isEnvTest = env === 'test'; | ||
| if (!isEnvDevelopment && !isEnvProduction && !isEnvTest) { | ||
| throw new Error( | ||
| 'Using `babel-preset-react-app` requires that you specify `NODE_ENV` or ' + | ||
| '`BABEL_ENV` environment variables. Valid values are "development", ' + | ||
| '"test", and "production". Instead, received: ' + | ||
| JSON.stringify(env) + | ||
| '.' | ||
| ); | ||
| } | ||
|
|
||
| return { | ||
| presets: [ | ||
| isEnvTest && [ | ||
| // ES features necessary for user's Node version | ||
| require('@babel/preset-env').default, | ||
| { | ||
| targets: { | ||
| node: 'current', | ||
| }, | ||
| }, | ||
| ], | ||
| (isEnvProduction || isEnvDevelopment) && [ | ||
| // Latest stable ECMAScript features | ||
| require('@babel/preset-env').default, | ||
| { | ||
| targets: { | ||
| // React parses on ie 9, so we should too | ||
| ie: 9, | ||
| }, | ||
| // We currently minify with uglify | ||
| // Remove after https://github.com/mishoo/UglifyJS2/issues/448 | ||
| forceAllTransforms: true, | ||
| // Disable polyfill transforms | ||
| useBuiltIns: false, | ||
| // Do not transform modules to CJS | ||
| modules: false, | ||
| }, | ||
| ], | ||
| [ | ||
| require('@babel/preset-react').default, | ||
| { | ||
| // Adds component stack to warning messages | ||
| // Adds __self attribute to JSX which React will use for some warnings | ||
| development: isEnvDevelopment || isEnvTest, | ||
| }, | ||
| ], | ||
| [require('@babel/preset-flow').default], | ||
| ].filter(Boolean), | ||
| plugins: [ | ||
| // Experimental macros support. Will be documented after it's had some time | ||
| // in the wild. | ||
| require('babel-plugin-macros'), | ||
| // class { handleClick = () => { } } | ||
| require('@babel/plugin-proposal-class-properties').default, | ||
| // The following two plugins use Object.assign directly, instead of Babel's | ||
| // extends helper. Note that this assumes `Object.assign` is available. | ||
| // { ...todo, completed: true } | ||
| [ | ||
| require('@babel/plugin-proposal-object-rest-spread').default, | ||
| { | ||
| useBuiltIns: true, | ||
| }, | ||
| ], | ||
| // Transforms JSX | ||
| [ | ||
| require('@babel/plugin-transform-react-jsx').default, | ||
| { | ||
| useBuiltIns: true, | ||
| }, | ||
| ], | ||
| // Polyfills the runtime needed for async/await and generators | ||
| [ | ||
| require('@babel/plugin-transform-runtime').default, | ||
| { | ||
| helpers: false, | ||
| polyfill: false, | ||
| regenerator: true, | ||
| }, | ||
| ], | ||
| // function* () { yield 42; yield 43; } | ||
| !isEnvTest && [ | ||
| require('@babel/plugin-transform-regenerator').default, | ||
| { | ||
| // Async functions are converted to generators by babel-preset-env | ||
| async: false, | ||
| }, | ||
| ], | ||
| // Adds syntax support for import() | ||
| require('@babel/plugin-syntax-dynamic-import').default, | ||
| isEnvTest && | ||
| // Transform dynamic import to require | ||
| require('babel-plugin-transform-dynamic-import').default, | ||
| ].filter(Boolean), | ||
| }; | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,24 @@ module.exports = { | |
| rules: [ | ||
| { | ||
| test: /\.js$/, | ||
| include: [ | ||
| path.resolve(__dirname, './src'), | ||
| path.dirname( | ||
| require.resolve('chalk', { | ||
| paths: path.dirname(require.resolve('@babel/code-frame')), | ||
| }) | ||
| ), | ||
| path.dirname( | ||
| require.resolve( | ||
| 'ansi-styles', | ||
| path.dirname( | ||
| require.resolve('chalk', { | ||
| paths: path.dirname(require.resolve('@babel/code-frame')), | ||
| }) | ||
|
There was a problem hiding this comment. All of this looks very fragile, why did we add it? There was a problem hiding this comment. Oh, okay. #3522 (comment) sigh There was a problem hiding this comment. It should be pretty reliable -- it resolves Same for Alternatively, we can just always compile those modules. |
||
| ) | ||
| ) | ||
| ), | ||
| ], | ||
| use: 'babel-loader', | ||
| }, | ||
| ], | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to use
import { codeFrameColumns } from '@babel/code-frame';, see https://www.npmjs.com/package/@babel/code-frame#upgrading-from-prior-versions