Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on Babel helpers #5093

Merged
merged 14 commits into from
Sep 25, 2018
Merged

Turn on Babel helpers #5093

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
775387a
Turn on helpers and test importing something with async/await works
Timer Sep 25, 2018
ca2777f
Compiling babel runtime breaks itself
Timer Sep 25, 2018
b86f9bd
Add helpers option to babel plugin with defaults
Timer Sep 25, 2018
937d786
Make helpers off by default and on in our configuration
Timer Sep 25, 2018
b74852a
Hit eject and e2e
Timer Sep 25, 2018
3cdbbfe
meh
Timer Sep 25, 2018
3dbc5f8
copy'n'paste
Timer Sep 25, 2018
2b06e8b
change again
Timer Sep 25, 2018
8ef839d
Turn off helpers by default in /prod, /dev, /test
Timer Sep 25, 2018
55a605b
oops
Timer Sep 25, 2018
071aa4f
Spread undefined
Timer Sep 25, 2018
82c82f8
Use object assign not object spread
Timer Sep 25, 2018
a404acc
Put preset in template since it's needed
Timer Sep 25, 2018
5bb2ee2
Fix e2e tests
Timer Sep 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-scripts/fixtures/kitchensink/.babelrc
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions tasks/e2e-kitchensink.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,10 @@ PORT=3001 \
nohup yarn start &>$tmp_server_log &
grep -q 'You can now view' <(tail -f $tmp_server_log)

# We haven't ejected yet which means there's no `babel` key
# in package.json yet
echo '{"presets":["react-app"]}' > .babelrc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just put it in our jest integration config or something? Why does it have to be at the root?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno what's best, but during eject we add it to package.json. Will file follow up issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just mean that in this case we only need it for integration test itself. So it's unrelated to our app and I'd like it to stay unrelated (if that makes sense)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. We'll figure something out.


# Test "development" environment
E2E_URL="http://localhost:3001" \
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
Expand Down