Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note on update to .flowconfig for .scss imports #5321

Merged
merged 2 commits into from
Oct 14, 2018
Merged

Added note on update to .flowconfig for .scss imports #5321

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4b4842
Added note on update to .flowconfig for .scss imports
rlueder Oct 5, 2018
29a6e3d
Mentioned .sass extension in note, added backticks
rlueder Oct 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/react-scripts/template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,13 @@ This will allow you to do imports like

> **Note:** You must prefix imports from `node_modules` with `~` as displayed above.

> **Note:** If you're using Flow, add the following to your .flowconfig so it'll recognize the .scss import.
Copy link
Contributor

@Timer Timer Oct 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include .sass as well, and wrap these in the inline code back ticks please: `.scss` (and .flowconfig).

Can you please make the code snippet inside of the quote?


```
[options]
module.file_ext=.scss
```

## Post-Processing CSS

This project setup minifies your CSS and adds vendor prefixes to it automatically through [Autoprefixer](https://github.com/postcss/autoprefixer) so you don’t need to worry about it.
Expand Down