Skip to content

Create .babelrc file on eject #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 45 additions & 35 deletions config/babel.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,41 +8,51 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/
// @remove-on-eject-end

var path = require('path');
var findCacheDir = require('find-cache-dir');

module.exports = {
// Don't try to find .babelrc because we want to force this configuration.
babelrc: false,
// This is a feature of `babel-loader` for webpack (not Babel itself).
// It enables caching results in ./node_modules/.cache/react-scripts/
// directory for faster rebuilds.
cacheDirectory: findCacheDir({ name: 'react-scripts' }),
presets: [
// Latest stable ECMAScript features
require.resolve('babel-preset-latest'),
// JSX, Flow
require.resolve('babel-preset-react')
],
plugins: [
// class { handleClick = () => { } }
require.resolve('babel-plugin-transform-class-properties'),
// { ...todo, completed: true }
require.resolve('babel-plugin-transform-object-rest-spread'),
// function* () { yield 42; yield 43; }
[require.resolve('babel-plugin-transform-regenerator'), {
// Async functions are converted to generators by babel-preset-latest
async: false
}],
// Polyfills the runtime needed for async/await and generators
[require.resolve('babel-plugin-transform-runtime'), {
helpers: false,
polyfill: false,
regenerator: true,
// Resolve the Babel runtime relative to the config.
// You can safely remove this after ejecting:
moduleName: path.dirname(require.resolve('babel-runtime/package'))
}]
]
module.exports = function (resolvePaths) {
return {
// Don't try to find .babelrc because we want to force this configuration.
babelrc: false,
presets: [
// Latest stable ECMAScript features
'babel-preset-latest',
// JSX, Flow
'babel-preset-react'
].map(function (preset) {
if (resolvePaths) {
return require.resolve(preset);
}

return preset;
}),
plugins: [
// class { handleClick = () => { } }
'babel-plugin-transform-class-properties',
// { ...todo, completed: true }
'babel-plugin-transform-object-rest-spread',
// function* () { yield 42; yield 43; }
['babel-plugin-transform-regenerator', {
// Async functions are converted to generators by babel-preset-latest
async: false
}],
// Polyfills the runtime needed for async/await and generators
['babel-plugin-transform-runtime', {
helpers: false,
polyfill: false,
regenerator: true,
// Resolve the Babel runtime relative to the config.
// You can safely remove this after ejecting:
moduleName: path.dirname(require.resolve('babel-runtime/package'))
}]
].map(function (plugin) {
if (resolvePaths) {
return Array.isArray(plugin) ?
[require.resolve(plugin[0]), plugin[1]] :
require.resolve(plugin);
}

return plugin;
})
}
};
87 changes: 51 additions & 36 deletions config/babel.prod.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,42 +8,57 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/
// @remove-on-eject-end

var path = require('path');

module.exports = {
// Don't try to find .babelrc because we want to force this configuration.
babelrc: false,
presets: [
// Latest stable ECMAScript features
require.resolve('babel-preset-latest'),
// JSX, Flow
require.resolve('babel-preset-react')
],
plugins: [
// class { handleClick = () => { } }
require.resolve('babel-plugin-transform-class-properties'),
// { ...todo, completed: true }
require.resolve('babel-plugin-transform-object-rest-spread'),
// function* () { yield 42; yield 43; }
[require.resolve('babel-plugin-transform-regenerator'), {
// Async functions are converted to generators by babel-preset-latest
async: false
}],
// Polyfills the runtime needed for async/await and generators
[require.resolve('babel-plugin-transform-runtime'), {
helpers: false,
polyfill: false,
regenerator: true,
// Resolve the Babel runtime relative to the config.
// You can safely remove this after ejecting:
moduleName: path.dirname(require.resolve('babel-runtime/package'))
}],
// Optimization: hoist JSX that never changes out of render()
// Disabled because of issues:
// * https://github.com/facebookincubator/create-react-app/issues/525
// * https://phabricator.babeljs.io/search/query/pCNlnC2xzwzx/
// TODO: Enable again when these issues are resolved.
// require.resolve('babel-plugin-transform-react-constant-elements')
]
module.exports = function (resolvePaths) {
return {
// Don't try to find .babelrc because we want to force this configuration.
babelrc: false,
presets: [
// Latest stable ECMAScript features
'babel-preset-latest',
// JSX, Flow
'babel-preset-react'
].map(function (preset) {
if (resolvePaths) {
return require.resolve(preset);
}

return preset;
}),
plugins: [
// class { handleClick = () => { } }
'babel-plugin-transform-class-properties',
// { ...todo, completed: true }
'babel-plugin-transform-object-rest-spread',
// function* () { yield 42; yield 43; }
['babel-plugin-transform-regenerator', {
// Async functions are converted to generators by babel-preset-latest
async: false
}],
// Polyfills the runtime needed for async/await and generators
['babel-plugin-transform-runtime', {
helpers: false,
polyfill: false,
regenerator: true,
// Resolve the Babel runtime relative to the config.
// You can safely remove this after ejecting:
moduleName: path.dirname(require.resolve('babel-runtime/package'))
}],
// Optimization: hoist JSX that never changes out of render()
// Disabled because of issues:
// * https://github.com/facebookincubator/create-react-app/issues/525
// * https://phabricator.babeljs.io/search/query/pCNlnC2xzwzx/
// TODO: Enable again when these issues are resolved.
// require.resolve('babel-plugin-transform-react-constant-elements')
].map(function (plugin) {
if (resolvePaths) {
return Array.isArray(plugin) ?
[require.resolve(plugin[0]), plugin[1]] :
require.resolve(plugin);
}

return plugin;
})
};
};
8 changes: 7 additions & 1 deletion config/jest/transform.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,13 @@
*/
// @remove-on-eject-end

const babelDev = require('../babel.dev');
const babelJest = require('babel-jest');

// After Eject
module.exports = babelJest.createTransformer();

// @remove-on-eject-begin
// Before Eject
const babelDev = require('../babel.dev')(true);
module.exports = babelJest.createTransformer(babelDev);
// @remove-on-eject-end
13 changes: 12 additions & 1 deletion config/webpack.config.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ var CaseSensitivePathsPlugin = require('case-sensitive-paths-webpack-plugin');
var WatchMissingNodeModulesPlugin = require('../scripts/utils/WatchMissingNodeModulesPlugin');
var paths = require('./paths');
var env = require('./env');
var findCacheDir = require('find-cache-dir');

// This is the development configuration.
// It is focused on developer experience and fast rebuilds.
Expand Down Expand Up @@ -107,7 +108,17 @@ module.exports = {
test: /\.(js|jsx)$/,
include: paths.appSrc,
loader: 'babel',
query: require('./babel.dev')
query: Object.assign({},
// @remove-on-eject-begin
require('./babel.dev')(true),
// @remove-on-eject-end
{
// This is a feature of `babel-loader` for webpack (not Babel itself).
// It enables caching results in ./node_modules/.cache/react-scripts/
// directory for faster rebuilds.
cacheDirectory: findCacheDir({ name: 'react-scripts' })
}
)
},
// "postcss" loader applies autoprefixer to our CSS.
// "css" loader resolves paths in CSS and adds assets as dependencies.
Expand Down
4 changes: 3 additions & 1 deletion config/webpack.config.prod.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ module.exports = {
test: /\.(js|jsx)$/,
include: paths.appSrc,
loader: 'babel',
query: require('./babel.prod')
// @remove-on-eject-begin
query: require('./babel.prod')(true)
// @remove-on-eject-end
},
// The notation here is somewhat confusing.
// "postcss" loader applies autoprefixer to our CSS.
Expand Down
46 changes: 44 additions & 2 deletions scripts/eject.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ var path = require('path');
var prompt = require('./utils/prompt');
var rimrafSync = require('rimraf').sync;
var spawnSync = require('cross-spawn').sync;
var babelDevConfig = require('../config/babel.dev.js')(false);
var babelProdConfig = require('../config/babel.prod.js')(false);

prompt(
'Are you sure you want to eject? This action is permanent.',
Expand All @@ -29,8 +31,6 @@ prompt(
var ownPath = path.join(__dirname, '..');
var appPath = path.join(ownPath, '..', '..');
var files = [
path.join('config', 'babel.dev.js'),
path.join('config', 'babel.prod.js'),
path.join('config', 'flow', 'css.js.flow'),
path.join('config', 'flow', 'file.js.flow'),
path.join('config', 'eslint.js'),
Expand Down Expand Up @@ -62,13 +62,25 @@ prompt(
}
});

// Ensure a .babelrc file doesn't exist in the app config folder
if (fs.existsSync(path.join(appPath, 'config', '.babelrc'))) {
console.error(
'config/.babelrc already exists in your app folder. We cannot ' +
'continue as you would lose all the changes in that file ' +
'Please delete it (maybe make a copy for backup) and run this ' +
'command again. You might have to manually merge your configs.'
);
process.exit(1);
}

// Copy the files over
fs.mkdirSync(path.join(appPath, 'config'));
fs.mkdirSync(path.join(appPath, 'config', 'flow'));
fs.mkdirSync(path.join(appPath, 'config', 'jest'));
fs.mkdirSync(path.join(appPath, 'scripts'));
fs.mkdirSync(path.join(appPath, 'scripts', 'utils'));


files.forEach(function(file) {
console.log('Copying ' + file + ' to ' + appPath);
var content = fs
Expand All @@ -82,6 +94,31 @@ prompt(
});
console.log();

// Create .babelrc from dev and prod configs
var babelrc = {
env: {
test: {
presets: babelDevConfig.presets,
plugins: babelDevConfig.plugins
},
development: {
presets: babelDevConfig.presets,
plugins: babelDevConfig.plugins
},
production: {
presets: babelProdConfig.presets,
plugins: babelProdConfig.plugins
}
}
};

console.log('Writing config/.babelrc to ' + appPath );
fs.writeFileSync(
path.join(appPath, 'config', '.babelrc'),
JSON.stringify(babelrc, null, 2)
);
console.log();

var ownPackage = require(path.join(ownPath, 'package.json'));
var appPackage = require(path.join(appPath, 'package.json'));

Expand Down Expand Up @@ -115,6 +152,11 @@ prompt(
extends: './config/eslint.js',
};

// Explicitly specify .babelrc config path
appPackage.babel = {
extends: './config/.babelrc'
};

console.log('Writing package.json');
fs.writeFileSync(
path.join(appPath, 'package.json'),
Expand Down