-
-
Notifications
You must be signed in to change notification settings - Fork 27k
add note about serviceWorker.js #6069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also a typed version of the serviceWorker.js
available in https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template-typescript/src/serviceWorker.ts
hmm. shouldn't the typed version be used by default if they are making a typescript app? |
Actually I'd say yes, it could be a follow up for #5549 |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution! |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Thanks for the PR. we have this file now. |
I followed these instructions and converted all the js files to ts and it failed to compile. Added a note about
serviceWorker.js
needing to be converted to ts, or left as js