#765 - Work on removing publish feature flags #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in cra.sh & release.sh
|
Hi, thanks for PR but I think the issue explicitly says:
as the very first line. @shubheksha I think you had some work in progress, could you push that? |
|
Hahaha I'm not sure how I missed that! Sorry was a very long day yesterday. Ok well no worries if this has been claimed, then. I don't want to be stepping on any toes. |
|
Well, since you already implemented it, it doesn’t really make sense to implement it twice. But please read the issue carefully the next time. |
Merged
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
…ng files in cra.sh & release.sh (facebook#861)
jarlef
pushed a commit
to jarlef/create-react-app
that referenced
this pull request
Nov 28, 2016
…ng files in cra.sh & release.sh (facebook#861)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Was poking around the repo and saw this #765 and thought I'd give it a shot.
I think this mostly works, but I've noticed a bit of destructive package.json touching during the process. Would love to get some feedback at this point and see if this is heading in the right direction.
Thanks!