Skip to content

Document tintColor option for ActionSheetIOS #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2017
Merged

Document tintColor option for ActionSheetIOS #36

merged 4 commits into from
Dec 11, 2017

Conversation

gianpaj
Copy link
Contributor

@gianpaj gianpaj commented Dec 7, 2017

also:

  • fixed the showActionSheetWithOptions example

This option was added in facebook/react-native#4590

FYI, this is not even documented in the comments
https://github.com/facebook/react-native/blob/master/Libraries/ActionSheetIOS/ActionSheetIOS.js#L28

Are the docs generated from the code? Should I update that instead?

also:
- fixed the `showActionSheetWithOptions` example

This option was added in facebook/react-native#4590

FYI, this is not even documented in the comments
https://github.com/facebook/react-native/blob/master/Libraries/ActionSheetIOS/ActionSheetIOS.js#L28

Are the docs generated from the code? Should I update that instead?
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@hramos
Copy link
Contributor

hramos commented Dec 7, 2017

The docs were initially generated from code, but going forward they will not be synced. Feel free to add any necessary comments back into the JS file.

The idea here is to have the full API reference documented on the website, while only having minimal comments for each method in the source code. It will take a while to update every source file to match this style but you can see an example of what we're going for here:
https://github.com/facebook/react-native/blob/master/Libraries/AppState/AppState.js

@hramos
Copy link
Contributor

hramos commented Dec 7, 2017

Can you make this change to the file in docs/ as well? Normally we would only update the docs/ version whenever an api is added/changed, but fixes like these are worth adding both to docs/ as well as versioned_docs/.

@hramos hramos merged commit 5a8dfd4 into facebook:master Dec 11, 2017
@gianpaj
Copy link
Contributor Author

gianpaj commented Dec 11, 2017

Thanks for fixing the conflicts. I didn't have time and now I know how I should have done it as well :)
👍 to RN

@gianpaj gianpaj deleted the patch-3 branch December 11, 2017 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants