Skip to content

Commit 9f112af

Browse files
f-melonifacebook-github-bot
authored andcommitted
Add comment to explain why production flag is used when Flipper is enabled (#33902)
Summary: Follow up of #33882 ## Changelog [Internal] - Add comment to explain why production flag is used when Flipper is enabled Pull Request resolved: #33902 Reviewed By: cortinico, f-meloni Differential Revision: D36632238 Pulled By: cipolleschi fbshipit-source-id: a859006851d9f50a4ad0ae1141006e8dac7aee6e
1 parent 8363184 commit 9f112af

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

scripts/cocoapods/flipper.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ def initialize(flipper_enabled, configurations, versions)
103103
end
104104

105105
def self.enabled(configurations = ["Debug"], versions = {})
106-
return FlipperConfiguration.new(true, configurations, versions)
106+
FlipperConfiguration.new(true, configurations, versions)
107107
end
108108

109109
def self.disabled
110-
return FlipperConfiguration.new(false, [], {})
110+
FlipperConfiguration.new(false, [], {})
111111
end
112112
end

scripts/react_native_pods.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,10 @@ def use_react_native! (options={})
111111
pod 'hermes-engine', :path => "#{prefix}/sdks/hermes/hermes-engine.podspec"
112112
end
113113

114+
# CocoaPods `configurations` option ensures that the target is copied only for the specified configurations,
115+
# but those dependencies are still built.
116+
# Flipper doesn't currently compile for release https://github.com/facebook/react-native/issues/33764
117+
# Setting the production flag to true when build for production make sure that we don't install Flipper in the app in the first place.
114118
if flipper_configuration.flipper_enabled && !production
115119
install_flipper_dependencies(prefix)
116120
use_flipper_pods(flipper_configuration.versions, :configurations => flipper_configuration.configurations)

0 commit comments

Comments
 (0)