Skip to content

Add comment to explain why production flag is used when Flipper is enabled #33902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add comment to explain why production flag is used when Flipper is enabled #33902

wants to merge 2 commits into from

Conversation

f-meloni
Copy link
Contributor

@f-meloni f-meloni commented May 24, 2022 •
edited
Loading

Summary

Follow up of #33882

Changelog

[Internal] - Add comment to explain why production flag is used when Flipper is enabled

Test Plan

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels May 24, 2022
@f-meloni f-meloni mentioned this pull request May 24, 2022
Closed
cipolleschi
cipolleschi requested changes May 24, 2022
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for addressing the community feedback.

I reworded a couple of sentences because they were not extremely clear to me. Let me know if you agree with the suggestions! 👍

@f-meloni
Improve comment
0306f3d 
Co-authored-by: Riccardo <[email protected]>
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 406a474
Branch: main

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @f-meloni in 9f112af.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 25, 2022
@leotm leotm mentioned this pull request Jun 20, 2022
Merged
21 tasks
@yungsters yungsters deleted the flipper_configuration_improvements branch August 12, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi requested changes

@tido64 tido64 tido64 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@f-meloni @analysis-bot @facebook-github-bot @react-native-bot @tido64 @cipolleschi