Fix Jest mocks for NetInfo module. #16722
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot label Core Team Generated by 🚫 dangerJS |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 10, 2017
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
cdlewis
pushed a commit
to cdlewis/react-native
that referenced
this pull request
Nov 19, 2017
Summary: Jest mock for `NetInfo.getConnectionInfo()` is missing. Tests are fail with error message: ``` TypeError: _reactNative.NetInfo.getConnectionInfo is not a function ``` And cleaned code in this files for unified code styles. Run test with usage of `NetInfo.getConnectionInfo()` [GENERAL] [BUGFIX] [jest/setup.js] - Fix Jest mocks for NetInfo module Closes facebook#16722 Differential Revision: D6298133 Pulled By: hramos fbshipit-source-id: 589cf6fed93965e7a09823015f2793f5c68a9c3b
shaundon
pushed a commit
to shaundon/react-native
that referenced
this pull request
Nov 20, 2017
Summary: Jest mock for `NetInfo.getConnectionInfo()` is missing. Tests are fail with error message: ``` TypeError: _reactNative.NetInfo.getConnectionInfo is not a function ``` And cleaned code in this files for unified code styles. Run test with usage of `NetInfo.getConnectionInfo()` [GENERAL] [BUGFIX] [jest/setup.js] - Fix Jest mocks for NetInfo module Closes facebook#16722 Differential Revision: D6298133 Pulled By: hramos fbshipit-source-id: 589cf6fed93965e7a09823015f2793f5c68a9c3b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Jest mock for
NetInfo.getConnectionInfo()is missing. Tests are fail with error message:And cleaned code in this files for unified code styles.
Test Plan
Run test with usage of
NetInfo.getConnectionInfo()Release Notes
[GENERAL] [BUGFIX] [jest/setup.js] - Fix Jest mocks for NetInfo module