update [email protected], [email protected], [email protected] #19325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
✅Test Plan
Missing Changelog
Generated by 🚫 dangerJS |
|
Why not just 3.1.2 and gradle 4 ? |
|
it has no breaking changes, but performance improvements. if we move to gradle plugin 3 or above, we need to deal with aapt2 and other breaking changes. as for now, aapt2 breaks compilation, and need to disable it explicitly. |
|
Then for me it's not neccessary to upgrade a middle version. And I thinks it's total okay to disable aapt2 since google not put much attension to it. |
|
You're free to choose your gradle and gradle plugin version for your project, it'll override react native. I use build tools 27 and latest gradle for my own. But for react native, we need smooth transition because many people depend on it |
|
new PR #19697 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we use build tools version 26, and makes it possible to use android gradle plugin 2.3.3 (requires build tools 25), gradle 3.x for improved build performance and developer experience. Also it will help targeting SDK 26 easier.
Android gradle plugin to 2.3.3 requires gradle version 3.3 or above, and gradle download task version 3.2.0 and above supports gradle version 3.3. Therefore, it's better to use latest gradle 3.x or 3.5, and gradle download task 3.4.0.
Test Plan
React Native and apps will build much faster and run as before.