Skip to content

[CI] Disable Appveyor builds on master branch #21835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Oct 17, 2018

Appveyor has been failing for over a month. I'm disabling the test on master until it's fixed.

Contributors may continue using Appveyor by including the appveyor.yml file in their fork.

See #20260 for more context.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2018
@empyrical
Copy link
Contributor

Can the AppVeyor hook be disabled while leaving the appveyor.yml in the repo?

- gradlew.bat RNTester:android:app:assembleRelease

test_script:
- npm test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Just remove test task.

@hramos
Copy link
Contributor Author

hramos commented Oct 18, 2018

@empyrical it's possible. I've updated Appveyor's settings, it will now look for the Appveyor config in .appveyor/config.yml. This effectively disables Appveyor on master and all forks, but you can still test if it's working by renaming appveyor.yml to .appveyor/config.yml in your own fork.

I'll close the PR.

@hramos hramos closed this Oct 18, 2018
facebook-github-bot pushed a commit that referenced this pull request Dec 4, 2018
Summary:
Enable ci for windows
appveyor pass.
#21835
 [GENERAL] [INTERNAL] [CI] - Enable ci for windows
Pull Request resolved: #22028

Differential Revision: D13318242

Pulled By: cpojer

fbshipit-source-id: be4b9b9fe6a4e21572f3d6c38b15a2acf8bb2662
grabbou pushed a commit that referenced this pull request Dec 17, 2018
Summary:
Enable ci for windows
appveyor pass.
#21835
 [GENERAL] [INTERNAL] [CI] - Enable ci for windows
Pull Request resolved: #22028

Differential Revision: D13318242

Pulled By: cpojer

fbshipit-source-id: be4b9b9fe6a4e21572f3d6c38b15a2acf8bb2662
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
Summary:
Enable ci for windows
appveyor pass.
facebook#21835
 [GENERAL] [INTERNAL] [CI] - Enable ci for windows
Pull Request resolved: facebook#22028

Differential Revision: D13318242

Pulled By: cpojer

fbshipit-source-id: be4b9b9fe6a4e21572f3d6c38b15a2acf8bb2662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants