-
Notifications
You must be signed in to change notification settings - Fork 24.7k
ReactActivity extends FragmentActivity #22662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
dulmandakh
wants to merge
9
commits into
facebook:master
from
dulmandakh:reactactivity-extends-fragmentactivity
Closed
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d12b4c0
ReactActivity extends FragmentActivity
dulmandakh aa4a63e
ReactFragmentActivity extends ReactActivity
dulmandakh e57e4fd
remove ReactFragmentActivity reference from ReactActivityDelegate
dulmandakh 418f0ef
Merge branch 'master' into reactactivity-extends-fragmentactivity
dulmandakh 1a2b58e
deprecation warning for ReactActivityDelegate having FragmentActivity
dulmandakh 69f45b7
RNTester accepts ReactActivity
dulmandakh 5b344c4
ReactActivityDelegate: remove constructor with FragmentActivity
dulmandakh a3ae63c
ReactActivityDelegate accepts just Activity
dulmandakh 73585d6
ReactActivityDelegate has 2 constructors for Activity and ReactActivity
dulmandakh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.