Fixed incorrect opacity behaviour for <Text> component on iOS #24435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed incorrect opacity behaviour for <Text> component on iOS
facebook-github-bot
added
CLA Signed
|
Closed
facebook-github-bot
approved these changes
Apr 15, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @shergin in d99e657. When will my fix make it into a release? | Upcoming Releases |
grabbou
pushed a commit
that referenced
this pull request
May 6, 2019
Summary: This PR fixes #24229. Seems currently `opacity` props for Text is being applied twice (one for text color and one for the whole view). This PR disables applying the prop to the text. [CATEGORY] [TYPE] - Fixed double applying opacity prop for Text Pull Request resolved: #24435 Differential Revision: D14932795 Pulled By: cpojer fbshipit-source-id: f9280fc75f788424cb5f1e42d2e79efdb354d645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #24229.
Seems currently
opacityprops for Text is being applied twice (one for text color and one for the whole view). This PR disables applying the prop to the text.Changelog
[CATEGORY] [TYPE] - Fixed double applying opacity prop for Text
Test Plan
See #24229 for more details.