-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Fix refs in Pressable leading to tree clone #39324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request was exported from Phabricator. Differential Revision: D49056493 |
Base commit: a228b0f |
|
Summary: `useImperativeHandle` without a dependencies array causes React to re-clone the tree, leading to undesirable layout effects. Changelog: [Internal] Reviewed By: fabriziocucci Differential Revision: D49056493
98b6ee3
to
8ba5e3a
Compare
This pull request was exported from Phabricator. Differential Revision: D49056493 |
Summary: `useImperativeHandle` without a dependencies array causes React to re-clone the tree, leading to undesirable layout effects. Changelog: [Internal] Reviewed By: fabriziocucci Differential Revision: D49056493
8ba5e3a
to
3850fa9
Compare
This pull request was exported from Phabricator. Differential Revision: D49056493 |
Summary: `useImperativeHandle` without a dependencies array causes React to re-clone the tree, leading to undesirable layout effects. Changelog: [Internal] Reviewed By: fabriziocucci Differential Revision: D49056493
3850fa9
to
4ef69e3
Compare
This pull request was exported from Phabricator. Differential Revision: D49056493 |
This pull request was successfully merged by @javache in cbf3b7d. When will my fix make it into a release? | Upcoming Releases |
This pull request has been merged in cbf3b7d. |
@javache I've applied this patch on I haven't tested it in normal Pressable, just wanted to bring this to your attention. |
The regression introduced in this PR was resolved by 15a2980 |
Summary:
useImperativeHandle
without a dependencies array causes React to re-clone the tree, leading to undesirable layout effects.Changelog: [Internal]
Differential Revision: D49056493