Skip to content

Replace usage of Java OptionalInt #45862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

huntie
Copy link
Member

@huntie huntie commented Aug 1, 2024

Summary:
Fixes compatibility with Android API < 24, and removes our JOptionalInt wrapper implementation for now.

Changelog: [Internal]

Differential Revision: D60581676

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 1, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60581676

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60581676

huntie added a commit to huntie/react-native that referenced this pull request Aug 1, 2024
Summary:
Pull Request resolved: facebook#45862

Fixes compatibility with Android API < 24, and removes our `JOptionalInt` wrapper implementation for now.

Changelog: [Internal]

Reviewed By: robhogan, motiz88

Differential Revision: D60581676
@huntie huntie force-pushed the export-D60581676 branch from ba6d72e to ce6437c Compare August 1, 2024 13:46
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60581676

huntie added a commit to huntie/react-native that referenced this pull request Aug 2, 2024
Summary:
Pull Request resolved: facebook#45862

Fixes compatibility with Android API < 24, and removes our `JOptionalInt` wrapper implementation for now.

Changelog: [Internal]

Reviewed By: robhogan, motiz88

Differential Revision: D60581676
@huntie huntie force-pushed the export-D60581676 branch from ce6437c to 538f119 Compare August 2, 2024 10:13
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60581676

huntie added a commit to huntie/react-native that referenced this pull request Aug 2, 2024
Summary:
Pull Request resolved: facebook#45862

Fixes compatibility with Android API < 24, and removes our `JOptionalInt` wrapper implementation for now.

Changelog: [Internal]

Reviewed By: robhogan, motiz88

Differential Revision: D60581676
@huntie huntie force-pushed the export-D60581676 branch from 538f119 to dcc3842 Compare August 2, 2024 13:23
Summary:
Pull Request resolved: facebook#45862

Fixes compatibility with Android API < 24, and removes our `JOptionalInt` wrapper implementation for now.

Changelog: [Internal]

Reviewed By: robhogan, motiz88

Differential Revision: D60581676
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60581676

@huntie huntie force-pushed the export-D60581676 branch from dcc3842 to 2e3e556 Compare August 5, 2024 11:31
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7b34870.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @huntie in 7b34870

When will my fix make it into a release? | How to file a pick request?

@huntie huntie deleted the export-D60581676 branch September 9, 2024 12:02
cipolleschi pushed a commit that referenced this pull request Sep 11, 2024
Summary:
Pull Request resolved: #45862

Fixes compatibility with Android API < 24, and removes our `JOptionalInt` wrapper implementation for now.

Changelog: [Internal]

Reviewed By: robhogan, motiz88

Differential Revision: D60581676

fbshipit-source-id: 7e79fc59a4199a967e62ac3aeafc5d5681c60077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants