Rename assertWhenLegacyArchitectureMinifyingEnabled to assertLegacyArchitecture
#50512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Reland of D72384347 ReactMarker is currently loading the whole `reactnativejni` which we should not be loading in NewArch. This is resulting in a warning fired for all the NewArch users with `legacyWarningsEnabled`. I'm cleaning this up by moving it inside `reactnativejni_common`. Changelog: [Internal] [Changed] - Move ReactMarker to `reactnativejni_common` as it's used in NewArch also Reviewed By: javache Differential Revision: D72552075
…yArchitecture` Summary: Reland of D72389708 This renames the method to be more aligned to the fact that we're using this entrypoint both for internal and for OSS users. I've also added a `assertLegacyArchitectureOnlyWhenMinifyEnabled` that will run only for internal builds. Changelog: [Internal] [Changed] - Differential Revision: D72552028
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72552028 |
|
This pull request has been merged in 82a40b6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reland of D72389708
This renames the method to be more aligned to the fact that we're using this entrypoint both for internal
and for OSS users.
I've also added a
assertLegacyArchitectureOnlyWhenMinifyEnabledthat will run only for internal builds.Changelog:
[Internal] [Changed] -
Differential Revision: D72552028