Bug: react-test-renderer: promise returned from `findByProps` query must be handled

[josias-r]

React (and react-test-renderer) version: 17.0.2
Eslint version: 8.6.0

Steps To Reproduce

1. create a ReactTestInstance using create from react-test-renderer
2. Try to run access findByProps of the root of ReactTestInstance
3. Eslint(testing-library/await-async-query) will show an error

code example:

// simulate nav toggle click event
create(<Nav onToggle={mockFunction} items={[]}></Nav>)
  .root.findByProps({
    className: "app__nav-toggler",
  })
  .props.onClick();

The current behavior

Eslint(testing-library/await-async-query) will show an error:

The expected behavior

Since the return type of findByProps is not actually a promise, the error should not appear. findByProps appears to be synchronous.

[bvaughn]

The lint rule in your bug report (testing-library/await-async-query) is for another project, testing-library. That library (and lint rule) are not related to the findByProps method of react-test-renderer. I think the lint rule, in this case, is just a false positive because the method name starts with "findBy".