Skip to content

Delete Suspense Fixture #15273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2019
Merged

Conversation

sebmarkbage
Copy link
Collaborator

As far as I can tell this build is broken. I get a build error claiming invalid syntax (for Flow features). Let's fix or delete. If I can't test, I can't patch it up when I break it.

As far as I can tell this build is broken. Let's fix or delete. If I can't
test, I can't patch it up when I break it.
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just started working on a different, more comprehensive one today. That one’s also broken, but for a valid reason — lacking primitives. So I can re-add later after solutions are in place. And it will serve as base for relevant recipes. But this one can go.

@sebmarkbage sebmarkbage merged commit a050f3d into facebook:master Mar 30, 2019
@shellscape
Copy link

@gaearon reminder to add that back in. the 16.x roadmap points to the now-removed directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants