Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Waku repro #30194

Closed
wants to merge 1 commit into from
Closed

Test for Waku repro #30194

wants to merge 1 commit into from

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jul 2, 2024

Should fail since that's what both Waku and Next.js repro: #30172

Test: yarn test --watch packages/react-client/src/__tests__/ReactFlight-test.js -t "nesting regression test"

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 11:29am

@eps1lon eps1lon marked this pull request as draft July 2, 2024 11:25
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Jul 2, 2024
Should fail since that's what both Waku and Next.js repro
@eps1lon eps1lon force-pushed the waku-repro-test branch from 46b5e25 to f6e8045 Compare July 2, 2024 11:27
@eps1lon eps1lon changed the title Passing test for Waku repro Test for Waku repro Jul 2, 2024
@react-sizebot
Copy link

Comparing: 6d2a97a...f6e8045

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.99 kB 497.99 kB = 89.27 kB 89.27 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.81 kB 502.81 kB = 89.97 kB 89.97 kB
facebook-www/ReactDOM-prod.classic.js = 597.08 kB 597.08 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.42 kB 571.42 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against f6e8045

@eps1lon
Copy link
Collaborator Author

eps1lon commented Jul 3, 2024

Replaced by #30198

@eps1lon eps1lon closed this Jul 3, 2024
@eps1lon eps1lon deleted the waku-repro-test branch July 3, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants