Skip to content

[Flight] Fully support serializing Map/Set in console logs #30295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-client/src/__tests__/ReactFlight-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2625,7 +2625,7 @@ describe('ReactFlight', () => {
return 'hello';
}
function ServerComponent() {
console.log('hi', {prop: 123, fn: foo});
console.log('hi', {prop: 123, fn: foo, map: new Map([['foo', foo]])});
throw new Error('err');
}

Expand Down Expand Up @@ -2667,6 +2667,13 @@ describe('ReactFlight', () => {
expect(typeof loggedFn).toBe('function');
expect(loggedFn).not.toBe(foo);
expect(loggedFn.toString()).toBe(foo.toString());

const loggedMap = mockConsoleLog.mock.calls[0][1].map;
expect(loggedMap instanceof Map).toBe(true);
const loggedFn2 = loggedMap.get('foo');
expect(typeof loggedFn2).toBe('function');
expect(loggedFn2).not.toBe(foo);
expect(loggedFn2.toString()).toBe(foo.toString());
});

it('uses the server component debug info as the element owner in DEV', async () => {
Expand Down
26 changes: 24 additions & 2 deletions packages/react-server/src/ReactFlightServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -2021,6 +2021,28 @@ function serializeSet(request: Request, set: Set<ReactClientValue>): string {
return '$W' + id.toString(16);
}

function serializeConsoleMap(
request: Request,
counter: {objectCount: number},
map: Map<ReactClientValue, ReactClientValue>,
): string {
// Like serializeMap but for renderConsoleValue.
const entries = Array.from(map);
const id = outlineConsoleValue(request, counter, entries);
return '$Q' + id.toString(16);
}

function serializeConsoleSet(
request: Request,
counter: {objectCount: number},
set: Set<ReactClientValue>,
): string {
// Like serializeMap but for renderConsoleValue.
const entries = Array.from(set);
const id = outlineConsoleValue(request, counter, entries);
return '$W' + id.toString(16);
}

function serializeIterator(
request: Request,
iterator: Iterator<ReactClientValue>,
Expand Down Expand Up @@ -3219,10 +3241,10 @@ function renderConsoleValue(
}

if (value instanceof Map) {
return serializeMap(request, value);
return serializeConsoleMap(request, counter, value);
}
if (value instanceof Set) {
return serializeSet(request, value);
return serializeConsoleSet(request, counter, value);
}
// TODO: FormData is not available in old Node. Remove the typeof later.
if (typeof FormData === 'function' && value instanceof FormData) {
Expand Down
Loading