Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fizz] fix empty string href double warning #31783

Merged
merged 7 commits into from
Jan 3, 2025
Merged

[fizz] fix empty string href double warning #31783

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
64a729e
[wip] switch to link
rickhanlonii Dec 14, 2024
abd1672
Try fix
rickhanlonii Dec 14, 2024
2ed94f4
revert test
rickhanlonii Dec 14, 2024
9d9f12f
fixes
rickhanlonii Dec 14, 2024
3ed3bd2
stupid linter
rickhanlonii Dec 14, 2024
3012d8b
Merge branch 'main' into rh/empty-string
rickhanlonii Dec 15, 2024
6052c9a
Allow hydrating empty string as null.
rickhanlonii Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 27 additions & 37 deletions packages/react-dom-bindings/src/client/ReactDOMComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2485,51 +2485,41 @@
case 'src':
case 'href':
if (
__DEV__ &&
value === '' &&
// <a href=""> is fine for "reload" links.
!(tag === 'a' && propKey === 'href') &&
!(tag === 'object' && propKey === 'data')
) {
if (__DEV__) {
if (propKey === 'src') {
console.error(
'An empty string ("") was passed to the %s attribute. ' +
'This may cause the browser to download the whole page again over the network. ' +
'To fix this, either do not render the element at all ' +
'or pass null to %s instead of an empty string.',
propKey,
propKey,
);
} else {
console.error(
'An empty string ("") was passed to the %s attribute. ' +
'To fix this, either do not render the element at all ' +
'or pass null to %s instead of an empty string.',
propKey,
propKey,
);
}
if (propKey === 'src') {
console.error(

Check failure on line 2495 in packages/react-dom-bindings/src/client/ReactDOMComponent.js

View workflow job for this annotation

GitHub Actions / Run eslint 

Wrap console.error() in an "if (__DEV__) {}" check
'An empty string ("") was passed to the %s attribute. ' +
'This may cause the browser to download the whole page again over the network. ' +
'To fix this, either do not render the element at all ' +
'or pass null to %s instead of an empty string.',
propKey,
propKey,
);
} else {
console.error(

Check failure on line 2504 in packages/react-dom-bindings/src/client/ReactDOMComponent.js

View workflow job for this annotation

GitHub Actions / Run eslint 

Wrap console.error() in an "if (__DEV__) {}" check
'An empty string ("") was passed to the %s attribute. ' +
'To fix this, either do not render the element at all ' +
'or pass null to %s instead of an empty string.',
propKey,
propKey,
);
}
hydrateSanitizedAttribute(
domElement,
propKey,
propKey,
null,
extraAttributes,
serverDifferences,
);
continue;
} else {
hydrateSanitizedAttribute(
domElement,
propKey,
propKey,
value,
extraAttributes,
serverDifferences,
);
continue;
}
hydrateSanitizedAttribute(
domElement,
propKey,
propKey,
value,
extraAttributes,
serverDifferences,
);
continue;
case 'action':
case 'formAction': {
const serverValue = domElement.getAttribute(propKey);
Expand Down
Loading