Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[assert helpers] react-dom (pt3) #31983

Merged
merged 5 commits into from
Jan 5, 2025

Conversation

rickhanlonii
Copy link
Member

moar assert helpers

this finishes all of react-dom except the server integration tests which are tricky to convert

Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2025 9:29pm

@react-sizebot
Copy link

react-sizebot commented Jan 5, 2025

Comparing: bf883be...f1f9c6c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 512.56 kB 512.56 kB = 91.61 kB 91.61 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 517.34 kB 517.34 kB = 92.46 kB 92.46 kB
facebook-www/ReactDOM-prod.classic.js = 594.36 kB 594.36 kB = 104.68 kB 104.69 kB
facebook-www/ReactDOM-prod.modern.js = 584.62 kB 584.62 kB = 103.14 kB 103.14 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 3bc643e

@rickhanlonii rickhanlonii merged commit 03e4ec2 into facebook:main Jan 5, 2025
187 checks passed
@rickhanlonii rickhanlonii deleted the rh/asserts/react-dom-pt-3 branch January 5, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants