Add Owner Stack to attribute hydration mismatches #32538
Merged
+444
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
changed the title
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/03-06-add_owner_stack_to_attribute_mismatches_during_hydration
branch
from
39d59ff to
d19b1e9
Compare
eps1lon
force-pushed
the
sebbie/03-06-add_owner_stack_to_attribute_mismatches_during_hydration
branch
from
d19b1e9 to
bb3c241
Compare
eps1lon
force-pushed
the
sebbie/03-06-add_owner_stack_to_attribute_mismatches_during_hydration
branch
from
bb3c241 to
907484a
Compare
sebmarkbage
approved these changes
Mar 6, 2025
eps1lon
deleted the
sebbie/03-06-add_owner_stack_to_attribute_mismatches_during_hydration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #32537
Summary
Adds an Owner Stack to attribute hydration mismatches e.g.
<div className={isClient ? 'client' : 'server'} />. We choose a Fiber depth-first as the Owner. I personally prefer something as close as possible to the origin and then work my way upwards if the fault is somewhere earlier. But we could also use a different heuristic based on the specific error.How did you test this change?