Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix node_modules cache glob #32604

Merged
merged 1 commit into from
Mar 14, 2025
Merged

[ci] Fix node_modules cache glob #32604

merged 1 commit into from
Mar 14, 2025

Conversation

poteto
Copy link
Member

@poteto poteto commented Mar 14, 2025 •
edited
Loading

Seems like the stringified cache path can cause some directories not to be cached, trying an alternative format

@poteto poteto mentioned this pull request Mar 14, 2025
Merged
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 14, 2025
@react-sizebot
Copy link

react-sizebot commented Mar 14, 2025 •
edited
Loading

Comparing: 6733870...89b63b3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 518.75 kB 518.75 kB = 92.47 kB 92.47 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 591.76 kB 591.76 kB = 105.36 kB 105.36 kB
facebook-www/ReactDOM-prod.classic.js = 652.39 kB 652.39 kB = 114.72 kB 114.72 kB
facebook-www/ReactDOM-prod.modern.js = 642.71 kB 642.71 kB = 113.15 kB 113.15 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against d454277

poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
[ci] Update yarn and node_modules cache key (#32603)
6733870 
Now that the compiler lint rule is merged into
eslint-plugin-react-hooks, we also need to update our caches so compiler
dependencies are also cached. This should fix the CI walltime regression
we are now seeing.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32603).
* #32604
* __->__ #32603
@poteto
[ci] Fix node_modules cache glob
d454277 
Seems like the stringified cache path can cause some directories not to be cached, trying an alternative format
@poteto poteto merged commit ef1103d into main Mar 14, 2025
226 of 227 checks passed
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
Revert "[ci] Fix node_modules cache glob (#32604)"
49a0cd5 
This reverts commit ef1103d.
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
[ci] Update node_modules cache path
30307e8 
Alternative of #32604. Also busts all caches
@poteto poteto mentioned this pull request Mar 14, 2025
Closed
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
[ci] Update node_modules cache path
f436f04 
Alternative of #32604.

Bust all old caches since I reverted some other changes to the keys.
@poteto poteto mentioned this pull request Mar 14, 2025
Merged
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
Revert "[ci] Fix node_modules cache glob (#32604)" (#32606)
e9d80d9 
This reverts commit ef1103d.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32606).
* #32609
* #32608
* #32607
* __->__ #32606
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
[ci] Update node_modules cache path
cb4e108 
Alternative of #32604.

Bust all old caches since I reverted some other changes to the keys.
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
[ci] Update node_modules cache path
15b9fe5 
Alternative of #32604.

Bust all old caches since I reverted some other changes to the keys.
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
[ci] Update node_modules cache path
1ae669e 
Alternative of #32604.

Bust all old caches since I reverted some other changes to the keys.
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
[ci] Update node_modules cache path
07c05fb 
Alternative of #32604.

Bust all old caches since I reverted some other changes to the keys.
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
[ci] Update node_modules cache path
f73f7ff 
Alternative of #32604.

Bust all old caches since I reverted some other changes to the keys.
github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
@poteto
Revert "[ci] Fix node_modules cache glob (#32604)" (#32606)
ba34cb6 
This reverts commit ef1103d.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32606).
* #32609
* #32608
* #32607
* __->__ #32606

DiffTrain build for [e9d80d9](e9d80d9)
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
[ci] Update node_modules cache path
2a2e487 
Alternative of #32604.

Bust all old caches since I reverted some other changes to the keys.
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
[ci] Update node_modules cache path
e4225b1 
Alternative of #32604.

Bust all old caches since I reverted some other changes to the keys.
poteto added a commit that referenced this pull request Mar 14, 2025
@poteto
[ci] Update node_modules cache path (#32609)
f3c9560 
Alternative of #32604.

Bust all old caches since I reverted some other changes to the keys.
github-actions bot pushed a commit to AreaLayer/react that referenced this pull request Mar 14, 2025
@22388o
[ci] Update node_modules cache path (facebook#32609)
bfb7baf 
Alternative of facebook#32604.

Bust all old caches since I reverted some other changes to the keys.

DiffTrain build for [f3c9560](facebook@f3c9560)
github-actions bot pushed a commit to AreaLayer/react that referenced this pull request Mar 14, 2025
@22388o
[ci] Update node_modules cache path (facebook#32609)
ee6a04a 
Alternative of facebook#32604.

Bust all old caches since I reverted some other changes to the keys.

DiffTrain build for [f3c9560](facebook@f3c9560)
@vercel-release-bot vercel-release-bot mentioned this pull request Mar 14, 2025
Merged
@poteto poteto deleted the pr32604 branch March 19, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poteto @react-sizebot @facebook-github-bot