Skip to content

[ci][ez] use yarn --cwd #32650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

[ci][ez] use yarn --cwd #32650

merged 3 commits into from
Mar 17, 2025

Conversation

poteto
Copy link
Member

@poteto poteto commented Mar 17, 2025

Run yarn install via --cwd instead of working-directory to make the labels clearer

Stack created with Sapling. Best reviewed with ReviewStack.

poteto added 2 commits March 17, 2025 13:58
In light of recent third party actions being compromised, let's just push the commit ourselves rather than use a third party action. We already detect if changes are needed, so the step will only run if so.

I also added a `dry_run` option to the manual runs of this workflow for testing.
Pins the discord webhook action to `86dc739f3f165f16dadc5666051c367efa1692f4`, which is what the v6 tag points to.
Run yarn install via `--cwd` instead of `working-directory` to make the labels clearer
@react-sizebot
Copy link

react-sizebot commented Mar 17, 2025

Comparing: 9320a01...ff2d1ec

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 517.29 kB = 92.26 kB 92.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 605.55 kB 605.55 kB = 107.43 kB 107.42 kB
facebook-www/ReactDOM-prod.classic.js = 651.92 kB 651.92 kB = 114.83 kB 114.83 kB
facebook-www/ReactDOM-prod.modern.js = 642.20 kB 642.20 kB = 113.24 kB 113.24 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against ff2d1ec

poteto added a commit that referenced this pull request Mar 17, 2025
In light of recent third party actions being compromised, let's just
push the commit ourselves rather than use a third party action. We
already detect if changes are needed, so the step will only run if so.

I also added a `dry_run` option to the manual runs of this workflow for
testing.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32648).
* #32650
* #32649
* __->__ #32648
poteto added a commit that referenced this pull request Mar 17, 2025
Pins the discord webhook action to
`86dc739f3f165f16dadc5666051c367efa1692f4`, which is what the v6 tag
points to.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32649).
* #32650
* __->__ #32649
* #32648
@poteto poteto merged commit ca02c4b into main Mar 17, 2025
195 of 199 checks passed
@poteto poteto deleted the pr32650 branch March 17, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants