[release] Don't lookup build-info.json when updating version numbers #32778
+2
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
jackpope
approved these changes
Mar 28, 2025
poteto
commented
Mar 28, 2025
Comment on lines
-155
to
-158
| // Replace inline renderer version numbers (e.g. shared/ReactVersion). | ||
| while (afterContents.indexOf(reactVersion) >= 0) { | ||
| afterContents = afterContents.replace(reactVersion, newStableVersion); | ||
| } |
There was a problem hiding this comment.
Since we pull all the same versions in this command, this 2nd loop is basically a no-op after the first one.
|
Comparing: ef4bc8b...6c5ca7a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
I missed this the last time.
From what we can see, `build-info.json` is a vestigal file that we were previously including in builds but are no longer since 2022 (see #23257, which removes `build-info.json` which would have broken scripts/release/build-release-locally-commands/add-build-info-json.js). Since this file is no longer built, instead of looking it up we default to the `version` that was passed in as an argument to scripts/release/prepare-release-from-npm.js. Since `version` is what is pulled from npm, there should only be 1 consistent version for all the packages that are pulled. Therefore, only 1 version (eg canary) needs to be replaced to the new stable version.
poteto
added a commit
that referenced
this pull request
Mar 28, 2025
I missed this the last time. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32777). * #32778 * __->__ #32777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what we can see,
build-info.jsonis a vestigal file that we were previously including in builds but are no longer since 2022 (see #23257, which removesbuild-info.jsonwhich would have broken scripts/release/build-release-locally-commands/add-build-info-json.js).Since this file is no longer built, instead of looking it up we default to the
versionthat was passed in as an argument to scripts/release/prepare-release-from-npm.js. Sinceversionis what is pulled from npm, there should only be 1 consistent version for all the packages that are pulled. Therefore, only 1 version (eg canary) needs to be replaced to the new stable version.Stack created with Sapling. Best reviewed with ReviewStack.