Follow through all the phases when an error happens during snapshotting #32803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: 450f8df...c2681eb Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
| @@ -1802,6 +1802,12 @@ export function startViewTransition( | |||
| } | |||
| } finally { | |||
| // Continue the reset of the work. | |||
| // If the error happened in the snapshot phase before the update callback | |||
| // was invoked, then we need to first finish the mutation and layout phases. | |||
| // If they're already invoked it's still safe to call them due the status check. | |||
There was a problem hiding this comment.
Suggested change
| // If they're already invoked it's still safe to call them due the status check. | |
| // If they're already invoked it's still safe to call them due to the status check. |
eps1lon
approved these changes
Apr 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
…ng (#32803) This can happen for example if you have duplicate names in the "old" state. This errors the transition before the updateCallback is invoked so we haven't yet applied mutations etc. This runs through those phases after the error to get us back to a consistent state. DiffTrain build for [040f828](040f828)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen for example if you have duplicate names in the "old" state. This errors the transition before the updateCallback is invoked so we haven't yet applied mutations etc.
This runs through those phases after the error to get us back to a consistent state.