-
Notifications
You must be signed in to change notification settings - Fork 48.7k
Fix Failed to execute 'measure' on 'Performance'
error
#32823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Failed to execute 'measure' on 'Performance'
error
#32823
Conversation
When `startTime` still has its initial value of `-1.1` we must not call `logComponentMount`. This can occur when rendering a `'next/dynamic'` component with `{ssr: false}` in a client component, for example. Unfortunately, I didn't manage to reproduce this scenario in a unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you
Comparing: 6a7650c...05a98de Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
This has a pair for offscreen too. You probably want to update that one as well. Usually these things come in twos. Offscreen/Regular or Mount/Unmount.
It seems unexpected though because we always call startProfilerTimer in the work loop: So how do we end up with a new Fiber that hasn't had its beginWork called yet we're visiting it in the passive mount phase? Seems like there's something deeper going on here that's worth looking into. |
When `startTime` still has its initial value of `-1.1` we must not call `logComponentMount`. This can occur when rendering a `'next/dynamic'` component with `{ssr: false}` in a client component, for example. Unfortunately, I didn't manage to reproduce this scenario in a unit test. DiffTrain build for [3366146](3366146)
[diff facebook/react@040f8286...33661467](facebook/react@040f828...3366146) <details> <summary>React upstream changes</summary> - facebook/react#32823 - facebook/react#32822 - facebook/react#32825 - facebook/react#32821 - facebook/react#32819 - facebook/react#32816 - facebook/react#32815 - facebook/react#32812 - facebook/react#32762 - facebook/react#32808 - facebook/react#32807 </details>
[diff facebook/react@040f8286...33661467](facebook/react@040f828...3366146) <details> <summary>React upstream changes</summary> - facebook/react#32823 - facebook/react#32822 - facebook/react#32825 - facebook/react#32821 - facebook/react#32819 - facebook/react#32816 - facebook/react#32815 - facebook/react#32812 - facebook/react#32762 - facebook/react#32808 - facebook/react#32807 </details>
When
startTime
still has its initial value of-1.1
we must not calllogComponentMount
. This can occur when rendering a'next/dynamic'
component with{ssr: false}
in a client component, for example. Unfortunately, I didn't manage to reproduce this scenario in a unit test.