Skeleton for store #33215
Open
Skeleton for store #33215
+128
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickhanlonii
requested review from
sebmarkbage,
captbaritone,
evanyeung and
josephsavona
github-actions
bot
added
the
React Core Team
|
Comparing: 4448b18...4a4147b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
approved these changes
May 15, 2025
captbaritone
approved these changes
May 15, 2025
gaearon
reviewed
May 16, 2025
| let assertLog; | ||
| let createStore; | ||
|
|
||
| describe('ReactUse', () => { |
nmn
reviewed
May 22, 2025
Comment on lines
+14
to
+17
| export function createStore<T>( | ||
| defaultValue: T, | ||
| reducer?: (T, mixed) => T, | ||
| ): ReactStore<T> { |
There was a problem hiding this comment.
This should be able have strong types for reducer actions while keeping both reducers and actions optional.
Suggested change
| export function createStore<T>( | |
| defaultValue: T, | |
| reducer?: (T, mixed) => T, | |
| ): ReactStore<T> { | |
| export function createStore<Value, Action = empty>( | |
| defaultValue: T, | |
| reducer?: (value: T, action?: Action) => T, | |
| ): ReactStore<T, Action> { |
Comment on lines
+22
to
+28
| const store: ReactStore<T> = { | ||
| $$typeof: REACT_STORE_TYPE, | ||
|
|
||
| _current: defaultValue, | ||
| _sync: defaultValue, | ||
| _transition: defaultValue, | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const store: ReactStore<T> = { | |
| $$typeof: REACT_STORE_TYPE, | |
| _current: defaultValue, | |
| _sync: defaultValue, | |
| _transition: defaultValue, | |
| }; | |
| const store: ReactStore<Value, mixed> = { | |
| $$typeof: REACT_STORE_TYPE, | |
| _current: defaultValue, | |
| _sync: defaultValue, | |
| _transition: defaultValue, | |
| }; |
Comment on lines
+67
to
+73
| export type ReactStore<T> = { | ||
| $$typeof: symbol, | ||
| _current: T, | ||
| _sync: T, | ||
| _transition: T, | ||
| }; | ||
|
|
There was a problem hiding this comment.
I'm not sure if the Action type makes sense anymore for this PR.
But the + should make the value co-variant, (making it possible to Store<Dog> where a Store<Animal> is needed)
While the - makes Action contra-variant (allowing you to pass a Dog when an Animal is accepted as/within an Action.)
Suggested change
| export type ReactStore<T> = { | |
| $$typeof: symbol, | |
| _current: T, | |
| _sync: T, | |
| _transition: T, | |
| }; | |
| export type ReactStore<+Value, -Action = empty> = { | |
| $$typeof: symbol, | |
| _current: Value, | |
| _sync: Value, | |
| _transition: Value, | |
| }; |
Would love support for asyncIterables some day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This doesn't do anything yet. Just sets up some of the skeleton, feature flags, and test files.
Conceptually there's an API to create a store, and then you can read the value with
use(store).For more info on our plans for this API, check out the React Labs post: