Fix ShapeNetDataset #593
Closed
Fix ShapeNetDataset #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@Talmaj thanks for the PR. I will review it and leave comments! |
|
@nikhilaravi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@nikhilaravi merged this pull request in 029a9da. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 22, 2021
Summary: include_package_data does not work well in the presence of built extensions, and the OSS build hasn't been working for a few days since #593 was merged. Reviewed By: patricklabatut Differential Revision: D29302315 fbshipit-source-id: db7e46f8c4593743c3522087979592f9989c7c6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include_package_data=Trueto include dataset .json files in the installationFix Error when loading ShapeNet #435
load_textures=Falsefor ShapeNetDataset with a testFix ShapeNet load_textures to False #450, partly fix Dataloaders Tutorial image-grid and visualization questions #444. I've set the textures to
None, if they should be all white instead, let me know.