Skip to content

Force allChunks to true - fix non-deterministic build #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2018
Merged

Force allChunks to true - fix non-deterministic build #63

merged 1 commit into from
Jun 4, 2018

Conversation

fdubost
Copy link

@fdubost fdubost commented Feb 22, 2018 •
edited
Loading

As you consider that allChunks is always true for shouldExtract, I think we should force it everywhere. It fixes a non-deterministic build for us: sometimes css-base.js file from css-loader lib was in the bundle, sometimes it wasn't the case and hashing wasn't consistent 😞

valotvince
valotvince approved these changes Feb 22, 2018
View reviewed changes
Copy link

@valotvince valotvince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@ScriptedAlchemy
Copy link
Collaborator

Merging this as the last minor update before a major version bump tomorrow #60 #71

@ScriptedAlchemy ScriptedAlchemy merged commit f4beee3 into faceyspacey:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flepretre flepretre flepretre approved these changes

@valotvince valotvince valotvince approved these changes

@DevSide DevSide DevSide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fdubost @ScriptedAlchemy @flepretre @valotvince @DevSide