👷 Improve playwright CI job #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick91
force-pushed
the
stop-on-flaky-tests
branch
from
666c29e to
c2328b4
Compare
patrick91
changed the title
|
Great, thank you! 🍰 🚀 |
d4vidsha
added a commit
to d4vidsha/scheduler
that referenced
this pull request
Oct 22, 2024
d4vidsha
added a commit
to d4vidsha/scheduler
that referenced
this pull request
Nov 12, 2024
* refactor: remove unnecessary attribute * chore: add information about MJML * chore: add `include-hidden-files` This is added to `upload-artefacts` GitHub action. * chore: improve playwright CI job fastapi/full-stack-fastapi-template#1335 (comment) * chore: see previous commit * feat: add db healthcheck * chore: bump axios 1.6.2 to 1.7.4 * chore: remove complexity of www * feat: simplify domains * feat: include `FRONTEND_HOST` in CORS origins by default * chore: upgrade FastAPI * refactor: move prestart (migrations) to own container * refactor: move location of scripts * chore: use official Python docker image * feat: use docker compose watch * chore: remove logic for dev deps * chore: add new Dockerfile * feat: add GH Action to lint * refactor: use top level `.env` * feat: auto-generate frontend client * chore: make it fail on errors * test: run tests from Python env * feat: use `uv` to generate client * chore: update GH Actions format * chore: use uv cache * chore: only commit on repo PRs; on forks, show error * fix: error * fix: log output directly to Docker * fix: exclude email-templates * chore: bump astral-sh/setup-uv from 2 to 3 * fix: enable logging for emails by default * refactor: use enc algo from settings * chore: bump rollup * refactor: add `PaginationFooter` component * fix: ignore `.auth` * feat: migrate from Poetry to `uv` * chore: add MailCatcher links * fix: checkout files in CI * fix: improve Playwright CI speed * chore: instructions to install runner * chore: change token name and commit * fix: remove dupe `dependabot.yml` * fix: add environment variables * fix: format backend * fix: missing `STACK_NAME` * fix: use `.env` file * fix: add `.env` files * fix: type errors * fix: add `frontend/.env` * fix: add `.env` file * chore: comment out tests
JBLangton
pushed a commit
to JBLangton/full-stack-fastapi-template
that referenced
this pull request
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
--fail-on-flaky-testsas a good practise to write less flaky tests, I assume in future you might want to disable this if your CI gets complex, but I think it should be turned on by default--trace=retain-on-failurefor easier debug when something fails (you can download the failing trace from the artifacts)[1] Ideally you'd do some additional checks to see if we are able to connect to the backend, but for CI this is enough (we can also add health checks for the db if needed) 😊