Skip to content

testing pydantic v1.10.0a2 #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

samuelcolvin
Copy link

TO NOT MERGE

This is pull request is just to test pydantic v1.10, see pydantic/pydantic#4359

@samuelcolvin
Copy link
Author

Hi, please can you kick off tests so I can check if v1.10 will break anything.

@github-actions
Copy link

📝 Docs preview for commit 79be9a0 at: https://6307617ba60b2a0e66a5e6a2--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit ca02707 at: https://63076590574691123cf98162--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit 0e56c91 at: https://630766b130edd013da479b12--sqlmodel.netlify.app

@byrman
Copy link
Contributor

byrman commented Aug 25, 2022

Be aware of #315. This might also cause some tests to fail.

@samuelcolvin
Copy link
Author

Be aware of #315. This might also cause some tests to fail.

Oh, thank you so much, I think that's what I was looking for.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #407 (22b2101) into main (4d20051) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   97.49%   97.34%   -0.15%     
==========================================
  Files         181      181              
  Lines        6037     6037              
==========================================
- Hits         5886     5877       -9     
- Misses        151      160       +9     
Impacted Files Coverage Δ
sqlmodel/main.py 81.73% <100.00%> (ø)
sqlmodel/sql/expression.py 74.35% <0.00%> (-23.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

📝 Docs preview for commit 22b2101 at: https://63076f3aff7afd1bc7235800--sqlmodel.netlify.app

@samuelcolvin
Copy link
Author

apart from the problems with black and sqlalchemy, this seems to be working.

it would appear that sqlmodel is compatible with pydantic v.10 👍 .

Thanks both for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants