Update fastify to v3 #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Apr 29, 2020
| @@ -0,0 +1 @@ | |||
| localhost:*:*:postgres:postgres | |||
There was a problem hiding this comment.
in the ci config we must set a POSTGRESS_PASSWORD value, and when we run the psql command it would prompt for a password, but if we provide a .pgpass file it will use that to get the password
| }) | ||
|
|
||
| next() | ||
| }) | ||
|
|
||
| fastify.register(function scopeTwo (instance, opts, next) { | ||
| instance.register(fastifyPostgres, { | ||
| connectionString: 'postgres://postgres@localhost/postgres', | ||
| connectionString: 'postgres://postgres:postgres@localhost/postgres', |
There was a problem hiding this comment.
maybe we can use .env to load those up? I think locally it could be different. It would also be different if Docker is used.
There was a problem hiding this comment.
It is the same locally as well. I updated to docker commands
51 tasks
Eomm
reviewed
May 3, 2020
Co-authored-by: Manuel Spigolon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmark