Skip to content

Bump dependencies old Ruby versions #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 12, 2023
Merged

Bump dependencies old Ruby versions #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
498174d
Bump dependencies
etagwerker Mar 11, 2023
8af9660
Consistent ruby versions
etagwerker Apr 30, 2023
b4355e2
Split dependencies old ruby
JuanVqz Jun 21, 2023
85cabac
Update to Linux 20.04
JuanVqz Jun 21, 2023
cf345d4
Update Ruby version into skunk.yml
JuanVqz Jul 3, 2023
d64d965
Address feedback
JuanVqz Jul 10, 2023
8f3bd10
Allow run CI
JuanVqz Jul 10, 2023
e94e5ab
Update CHANGELOG
JuanVqz Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
# .github/workflows/main.yml

name: CI
on:
push:
branches:
- main
pull_request:
branches:
- main
on: [push, pull_request]

jobs:
test-ruby-2-4-x:
Expand Down Expand Up @@ -47,7 +41,7 @@ jobs:
strategy:
matrix:
os: [ubuntu]
ruby-version: [2.6, 2.7, "3.0", 3.1, 3.2]
ruby-version: ["2.6", "2.7", "3.0", "3.1", "3.2"]
steps:
- uses: actions/checkout@v2
- name: Setup Ruby ${{ matrix.ruby-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/skunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6
ruby-version: 3.1
bundler-cache: true
- name: Run test suite with COVERAGE=true
run: |
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* <INSERT YOUR FEATURE OR BUGFIX HERE>

* [BUGFIX: Update reek, rubocop, and terminal-table dependencies](https://github.com/fastruby/skunk/pull/111)
* [BUGFIX: Better test coverage tracking for skunk](https://github.com/fastruby/skunk/pull/108)
* [FEATURE: Add Ruby 3.2 Support](https://github.com/fastruby/skunk/pull/106)
* [BUGFIX: Fix skunk workflow](https://github.com/fastruby/skunk/pull/104)
Expand Down
2 changes: 2 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
# Specify your gem's dependencies in skunk.gemspec
gemspec

gem "reek", "~> 6.1"
gem "rubocop", "~> 1.48"
gem "vcr", "~> 6.1.0"
2 changes: 2 additions & 0 deletions Gemfile-Ruby-2-4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
# Specify your gem's dependencies in skunk.gemspec
gemspec

gem "reek", "~> 6.0.0"
gem "rubocop", "~> 1.0"
gem "simplecov", "< 0.19.0"
gem "vcr", "< 6.1.0"
2 changes: 2 additions & 0 deletions Gemfile-Ruby-2-5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
# Specify your gem's dependencies in skunk.gemspec
gemspec

gem "reek", "~> 6.0.0"
gem "rubocop", "~> 1.0"
gem "simplecov", "< 0.19.0"
gem "vcr", "< 6.1.0"
6 changes: 3 additions & 3 deletions skunk.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.add_dependency "rubycritic", ">= 4.5.2", "< 5.0"
spec.add_dependency "terminal-table", "~> 1.8.0"
spec.add_dependency "terminal-table", "~> 3.0"

spec.add_development_dependency "codecov", "~> 0.1.16"
spec.add_development_dependency "debug"
Expand All @@ -48,8 +48,8 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "minitest-stub_any_instance", "~> 1.0.2"
spec.add_development_dependency "minitest-stub-const", "~> 0.6"
spec.add_development_dependency "rake", "~> 13.0"
spec.add_development_dependency "reek", "~> 6.0.0"
spec.add_development_dependency "rubocop", "~> 1.0"
spec.add_development_dependency "reek"
spec.add_development_dependency "rubocop"
spec.add_development_dependency "simplecov", "~> 0.18"
spec.add_development_dependency "simplecov-console", "0.5.0"
spec.add_development_dependency "webmock", "~> 3.10.0"
Expand Down