-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: Replace zod by protobufjs #3208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6207be4
to
098082d
Compare
197f50d
to
3679a2b
Compare
Two issues pending
Except for these two issues, the UI works like a charm with the new protobufjs parsers |
Looks like there's still some outstanding issues in showing enum values (e.g. data source enum types) |
Codecov ReportBase: 67.71% // Head: 57.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3208 +/- ##
==========================================
- Coverage 67.71% 57.93% -9.78%
==========================================
Files 181 215 +34
Lines 16615 18062 +1447
==========================================
- Hits 11251 10465 -786
- Misses 5364 7597 +2233
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Jérôme Viveret <[email protected]> Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, jerive The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* feat: Replace zod by protobufjs Signed-off-by: Jérôme Viveret <[email protected]> Signed-off-by: Danny Chiao <[email protected]> * Remove unneeded pages and fix bugs Signed-off-by: Danny Chiao <[email protected]> * Update the ui_server Signed-off-by: Danny Chiao <[email protected]> * Replace manually generated json registry by protobuf version Signed-off-by: Danny Chiao <[email protected]> * Correctly display protobufjs enums Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: Jérôme Viveret <[email protected]> Signed-off-by: Danny Chiao <[email protected]> Co-authored-by: Jérôme Viveret <[email protected]> Co-authored-by: Danny Chiao <[email protected]>
* feat: Replace zod by protobufjs Signed-off-by: Jérôme Viveret <[email protected]> Signed-off-by: Danny Chiao <[email protected]> * Remove unneeded pages and fix bugs Signed-off-by: Danny Chiao <[email protected]> * Update the ui_server Signed-off-by: Danny Chiao <[email protected]> * Replace manually generated json registry by protobuf version Signed-off-by: Danny Chiao <[email protected]> * Correctly display protobufjs enums Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: Jérôme Viveret <[email protected]> Signed-off-by: Danny Chiao <[email protected]> Co-authored-by: Jérôme Viveret <[email protected]> Co-authored-by: Danny Chiao <[email protected]>
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #