Skip to content

chore: Replace zod by protobufjs #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Conversation

jerive
Copy link
Contributor

@jerive jerive commented Sep 13, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@jerive jerive force-pushed the zod_to_pbjs branch 2 times, most recently from 6207be4 to 098082d Compare September 13, 2022 08:06
@jerive jerive changed the title [DRAFT] Replace zod by protobufjs feat: Replace zod by protobufjs Sep 13, 2022
@jerive jerive force-pushed the zod_to_pbjs branch 12 times, most recently from 197f50d to 3679a2b Compare September 19, 2022 12:54
@jerive
Copy link
Contributor Author

jerive commented Oct 5, 2022

Two issues pending

  1. Conversion from JSON fails for google.protobuf.Timestamp types (kind of expected, string != {seconds, nanos}) => the UI ends up needing a protobuf binary instead of the JSON string that is exposed today by the backend (unless we find a way to do automatic conversion, which I have not found yet how to do ; we could do regex search/replace but it does not feel like the right way 🙂 )
  2. I have not found a proto equivalent for featureViewSummaryStatistics and I am still figuring out what to do. Certainly you know better than I do

Except for these two issues, the UI works like a charm with the new protobufjs parsers

@adchia adchia marked this pull request as ready for review October 5, 2022 15:31
@adchia adchia self-requested a review as a code owner October 5, 2022 15:31
@adchia
Copy link
Collaborator

adchia commented Oct 5, 2022

Looks like there's still some outstanding issues in showing enum values (e.g. data source enum types)

@adchia adchia self-assigned this Oct 5, 2022
@adchia adchia changed the title feat: Replace zod by protobufjs chore: Replace zod by protobufjs Oct 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Base: 67.71% // Head: 57.93% // Decreases project coverage by -9.77% ⚠️

Coverage data is based on head (408bd9c) compared to base (6bc91c2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3208      +/-   ##
==========================================
- Coverage   67.71%   57.93%   -9.78%     
==========================================
  Files         181      215      +34     
  Lines       16615    18062    +1447     
==========================================
- Hits        11251    10465     -786     
- Misses       5364     7597    +2233     
Flag Coverage Δ
integrationtests ?
unittests 57.93% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/ui_server.py 23.91% <0.00%> (ø)
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...fline_store/test_universal_historical_retrieval.py 28.75% <0.00%> (-71.25%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 31.34% <0.00%> (-68.66%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.67%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
... and 168 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, jerive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit c9820ca into feast-dev:master Oct 5, 2022
kevjumba pushed a commit that referenced this pull request Oct 6, 2022
* feat: Replace zod by protobufjs

Signed-off-by: Jérôme Viveret <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>

* Remove unneeded pages and fix bugs

Signed-off-by: Danny Chiao <[email protected]>

* Update the ui_server

Signed-off-by: Danny Chiao <[email protected]>

* Replace manually generated json registry by protobuf version

Signed-off-by: Danny Chiao <[email protected]>

* Correctly display protobufjs enums

Signed-off-by: Danny Chiao <[email protected]>

Signed-off-by: Jérôme Viveret <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Co-authored-by: Jérôme Viveret <[email protected]>
Co-authored-by: Danny Chiao <[email protected]>
@jerive jerive mentioned this pull request Oct 6, 2022
franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request Oct 18, 2022
* feat: Replace zod by protobufjs

Signed-off-by: Jérôme Viveret <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>

* Remove unneeded pages and fix bugs

Signed-off-by: Danny Chiao <[email protected]>

* Update the ui_server

Signed-off-by: Danny Chiao <[email protected]>

* Replace manually generated json registry by protobuf version

Signed-off-by: Danny Chiao <[email protected]>

* Correctly display protobufjs enums

Signed-off-by: Danny Chiao <[email protected]>

Signed-off-by: Jérôme Viveret <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Co-authored-by: Jérôme Viveret <[email protected]>
Co-authored-by: Danny Chiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants