-
Notifications
You must be signed in to change notification settings - Fork 12
InventoryItem deprecation warning since Sphinx 8.2.0 #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks! I'll have a look at what we can do 👌 |
It seems that there's some internal work happening to inventories (sphinx-doc/sphinx#13275). Since the type is private and the implementation is "initial", I don't really want to rush changes. Let's see how it develops 👍 Although if you have good ideas on how we can go around this while supporting older Sphinx versions, I'd be interested! |
I have for now given up supporting Sphinx 8.2 (spatialaudio/nbsphinx#828), so I'm in no hurry! |
@felix-hilden the relevant PR is sphinx-doc/sphinx#13248, introducing However, if you are happy with the deprecation warnings it would be useful for your users to silence them, similarly to how Sphinx silences selected Docutils warnings: warnings.filterwarnings(
'ignore',
'The tuple interface for _InventoryItem objects.*',
RemovedInSphinx10Warning,
module='...',
) |
@mgeier fair enough, good to know! @AA-Turner Thank you for the guidance! I didn't realise it was meant to be a ready public change already 👌 I think we might ignore the warnings and set an upper bound to Sphinx<10. Then when the time comes to upgrade we can switch the implementation around and support >8.2. |
In general upper bounds are unhelpful for Python packages (Henry Schreiner has articles on this). Are you able to condition on A |
Fair enough, we could even though testing becomes a bit awkward if we keep going down that road. But with only this it's not so bad 👍 |
Issue
I have tested the upcoming Sphinx version (using Sphinx 8.2.0rc1) and got this warning:
See sphinx-doc/sphinx#13325 for Sphinx release plan.
Expected behavior
No warning.
Steps to reproduce
See https://github.com/mgeier/nbsphinx/actions/runs/13377728736/job/37360423578
The text was updated successfully, but these errors were encountered: