Skip to content

Signature help #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixfbecker opened this issue Sep 9, 2016 · 4 comments · Fixed by felixfbecker/vscode-php-intellisense#226
Closed

Signature help #18

felixfbecker opened this issue Sep 9, 2016 · 4 comments · Fixed by felixfbecker/vscode-php-intellisense#226
Labels

Comments

@felixfbecker
Copy link
Owner

felixfbecker commented Sep 9, 2016

https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#signature-help-request

image

@vakata
Copy link
Contributor

vakata commented Jan 20, 2017

Hello,

I made a very crude attempt at implementing signature help.

It works well enough for me, but I did not create a PR, because:

  1. To improve resolving I had to open the current file and do some seeking: vakata@3b4e0c3#diff-419997c105b8230a20d50dd0d9f907d6R63
  2. I had to resort to using some custom token stacking logic on top of the Lexer class in order to find the active parameter which is an ugly hack and not very elegant: vakata@8995611

Still, I thought I'd share, some parts may be useful:
https://github.com/vakata/php-language-server/commits/signatureHelp

@felixfbecker
Copy link
Owner Author

Open a PR, it's better to discuss it there :)

@codewp
Copy link

codewp commented Mar 5, 2017

Please let me know when this feature comes to VS Code?
I think that this feature is a most used feature by developers.

Thanks.

@felixfbecker
Copy link
Owner Author

@codewp there's a subscribe button on the right side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants