Skip to content

update libvpx & libwebp to latest releases #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

jzern
Copy link
Contributor

@jzern jzern commented Nov 15, 2023

libvpx: 1.13.1
libwebp: 1.3.2

libvpx: 1.13.1
libwebp: 1.3.2
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for ffmpegwasm ready!

Name Link
🔨 Latest commit 1d72f8d
🔍 Latest deploy log https://app.netlify.com/sites/ffmpegwasm/deploys/6580bffd086f9700085783a1
😎 Deploy Preview https://deploy-preview-629--ffmpegwasm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jzern
Copy link
Contributor Author

jzern commented Nov 15, 2023

I have a couple of questions unrelated to this commit:

  1. Is there any interest in adding support for libaom (AV1 / AVIF encoding?)
  2. libvpx uses --target=generic-gnu was there an issue building the x86 optimizations for

@jeromewu
Copy link
Collaborator

@jzern Thanks for the contribution, but after testing I found that there is no problem to upgrade libvpx to 1.13.1, but upgrading libwebp to 1.2.0+ results in the error below:
image

Thus, I think libwebp 1.2.1+ is not compatible with ffmpeg n5.1.3 / n5.1.4.

May I trouble you to update this PR to upgrade libvpx to 1.13.1 and libwebp to 1.2.0? Thanks.

@jeromewu jeromewu added the help wanted Extra attention is needed label Dec 17, 2023
@jzern
Copy link
Contributor Author

jzern commented Dec 18, 2023

Thanks for the contribution, but after testing I found that there is no problem to upgrade libvpx to 1.13.1, but upgrading libwebp to 1.2.0+ results in the error below:

WebPAnimEncoder* come from libwebpmux; see ffmpeg's configure check 1. The motivation behind this change is to ensure the snapshot has all available bug and security fixes. An option is to update to a commit on the 1.2.0 release branch, but I'd prefer is this can get fixed so this code base has the latest code.

How can I reproduce the issue?

@jzern
Copy link
Contributor Author

jzern commented Dec 18, 2023

I see the issue using make dev. Maybe there was an issue in the ffmpeg snapshot you are using. v1.2.0-8-g20ceff7e is a fallback on the 1.2.0 branch.

libwebpmux is required for libwebp_anim_encoder. libsharpyuv is required
by libwebp since 1.3.0.
@jzern
Copy link
Contributor Author

jzern commented Dec 18, 2023

@jeromewu this should be fixed now.
I didn't notice in my original change that the libs are explicitly named in Dockerfile and passed ffmpeg-wasm.sh.

@jeromewu
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants