Skip to content

chore: add selector retrieval tests #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 29, 2023

On top of #1647

It'd be great to run these against booster-http too; we could just run an http client directly and request the CAR and do the same inspection.

@rvagg rvagg requested review from dirkmc and LexLuthr August 29, 2023 06:54
Copy link
Collaborator

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of nits.

@rvagg
Copy link
Member Author

rvagg commented Aug 29, 2023

pushed a fixup (remember to squash merge this if I don't beforehand)

@LexLuthr
Copy link
Collaborator

@rvagg it looks like we are missing the circleCI config to trigger this new itest. Can you add that as well?

@LexLuthr LexLuthr merged commit eda484a into bump-b-graphsync Aug 29, 2023
@LexLuthr LexLuthr deleted the rvagg/selector-retrieval-tests branch August 29, 2023 11:04
LexLuthr added a commit that referenced this pull request Aug 29, 2023
* bump boost-graphsync to v0.13.7

* chore: add selector retrieval tests (#1652)

---------

Co-authored-by: Rod Vagg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants