Skip to content

feat(firebase_ui_auth): Use icon from OAuth provider as a fallback in ProfileScreen #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Rexios80
Copy link
Contributor

@Rexios80 Rexios80 commented Feb 18, 2025

Description

In the ProfileScreen, use the OAuth provider icon as a fallback if available

Replaces #451

Related Issues

closes #383

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Rexios80
Copy link
Contributor Author

@russellwheatley any comments on this?

Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale Issue with no recent activity label Apr 18, 2025
@Rexios80
Copy link
Contributor Author

@russellwheatley any thoughts?

@github-actions github-actions bot removed the Stale Issue with no recent activity label Apr 18, 2025
@russellwheatley russellwheatley merged commit 55f04eb into firebase:main Apr 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_ui_auth] Do not throw an exception if provider icon is not found in ProfileScreen
2 participants