Skip to content

Add test for duplicate entrypoints #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2023
Merged

Conversation

bourdakos1
Copy link
Contributor

@bourdakos1 bourdakos1 commented Jan 8, 2023

Add a main function to spm tests to test that the package doesn't include any other entrypoints, which would cause duplicate symbol errors when including abseil in an app.

See failing test from including benchmark file with a "main" function: https://github.com/firebase/abseil-cpp-SwiftPM/actions/runs/3868703055/jobs/6594320455#step:4:714

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulb777 paulb777 merged commit ec90126 into firebase:main Jan 8, 2023
@bourdakos1 bourdakos1 deleted the symbol-test branch January 8, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants