Skip to content

Import abseil-cpp source tag 20230802.0 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

HannahShiSFB
Copy link
Collaborator

Resubmit #17

@paulb777 Can you help trigger the CI on this PR?
I manually ran the commands in spm.yml, they all succeeded.

@paulb777
Copy link
Member

@HannahShiSFB CI should now automatically run on any PR. It had been disabled because of no activity on the repo for 90 days.

Looks like it's failing ...

@HannahShiSFB
Copy link
Collaborator Author

Yeah, same redundant module import error, looking...

@HannahShiSFB
Copy link
Collaborator Author

Looks like we need to ignore the include warning for it to work, previous patch #9

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

We may want to merge #21 to support the current version with a privacy manifest and keep the commit history linear.

cc: @ncooke3

@ncooke3
Copy link
Member

ncooke3 commented Jan 24, 2024

We may want to merge #21 to support the current version with a privacy manifest and keep the commit history linear.

#21 LGTM–– thanks @HannahShiSFB.

@paulb777, should I go ahead and merge #21 before this PR merges, then?

@paulb777
Copy link
Member

Probably. Let's sync on the tagging strategy when we meet today.

@paulb777 paulb777 merged commit 421664c into firebase:main Jan 24, 2024
@paulb777
Copy link
Member

Merged and published a 0.20230802.0 tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants