PR fixes

Author: lahirumaramba

src/remote-config/remote-config-api-client.ts

@@ -237,9 +237,6 @@ export class RemoteConfigApiClient {
   public listVersions(options?: ListVersionsOptions): Promise<ListVersionsResult> {
     if (typeof options !== 'undefined') {
       options = this.validateListVersionsOptions(options);
-      // Remove undefined fields from options
-      Object.keys(options).forEach(key =>
-        (options as any)[key] === undefined && delete (options as any)[key])
     }
     return this.getUrl()
       .then((url) => {
@@ -480,6 +477,10 @@ export class RemoteConfigApiClient {
         optionsCopy.endTime = new Date(optionsCopy.endTime).toISOString();
       }
     }
+    // Remove undefined fields from optionsCopy
+    Object.keys(optionsCopy).forEach(key =>
+      (typeof (optionsCopy as any)[key] === 'undefined') && delete (optionsCopy as any)[key]
+    );
     return optionsCopy;
   }
 }

src/remote-config/remote-config.ts

@@ -144,10 +144,8 @@ export class RemoteConfig implements FirebaseServiceInterface {
   public listVersions(options?: ListVersionsOptions): Promise<ListVersionsResult> {
     return this.client.listVersions(options)
       .then((listVersionsResponse) => {
-        const versions = (typeof listVersionsResponse.versions == 'undefined') ? [] :
-          listVersionsResponse.versions.map(version => new VersionImpl(version));
         return {
-          versions,
+          versions: listVersionsResponse.versions?.map(version => new VersionImpl(version)) ?? [],
           nextPageToken: listVersionsResponse.nextPageToken,
         }
       });

test/integration/remote-config.spec.ts

@@ -70,7 +70,7 @@ const VALID_CONDITIONS: admin.remoteConfig.RemoteConfigCondition[] = [
   },
 ];
 
-const VALID_VERSION: admin.remoteConfig.Version = {
+const VALID_VERSION = {
   description: `template description ${Date.now()}`,
 }
 
@@ -149,7 +149,7 @@ describe('admin.remoteConfig', () => {
   });
 
   describe('getTemplate', () => {
-    it('verfy that getTemplate() returns the most recently published template', () => {
+    it('should return the most recently published template', () => {
       return admin.remoteConfig().getTemplate()
         .then((template) => {
           expect(template.etag).matches(/^etag-[0-9]*-[0-9]*$/);
@@ -186,7 +186,7 @@ describe('admin.remoteConfig', () => {
       versionTwoNumber = activeTemplate.version!.versionNumber!;
     });
 
-    it('verfy that getTemplateAtVersion() returns the requested template version v1', () => {
+    it('should return the requested template version v1', () => {
       return admin.remoteConfig().getTemplateAtVersion(versionOneNumber)
         .then((template) => {
           expect(template.etag).matches(/^etag-[0-9]*-[0-9]*$/);
@@ -195,16 +195,6 @@ describe('admin.remoteConfig', () => {
           expect(template.version!.description).equals(versionOneDescription);
         });
     });
-
-    it('verfy that getTemplateAtVersion() returns the requested template version v2', () => {
-      return admin.remoteConfig().getTemplateAtVersion(versionTwoNumber)
-        .then((template) => {
-          expect(template.etag).matches(/^etag-[0-9]*-[0-9]*$/);
-          expect(template.version).to.be.not.undefined;
-          expect(template.version!.versionNumber).equals(versionTwoNumber);
-          expect(template.version!.description).equals(versionTwoDescription);
-        });
-    });
   });
 
   describe('listVersions', () => {