-
Notifications
You must be signed in to change notification settings - Fork 391
Type issue in 8.12 conflicts with firebase-functions #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Huh. Conceptually, I think this should be Though the more general problem is what should happen when we change anything to one of our interfaces. I didn't realise that functions implemented auth's interfaces; it seems that just about any change would cause it to break? (Short of marking everything as optional, which seems slightly unfriendly to consumers of the interface.) Possible solutions:
I'll leave the decision to @hiranya911 |
I guess it depends on if we are intentionally exporting these interfaces. Also we might want to make a distinction on input types (that developers have to create) and export types (things we return). Adding fields to the latter is not a big deal, adding fields to the former is breaking. |
But I suppose we cannot control how people use any of our interfaces, regardless of whether they are just output types or not. People might implement them for various reasons (testing, extending etc). So we basically cannot add/remove required fields in any of our existing interfaces. @rsgowman can we go ahead and change this to |
While it's always present (even if null), having it optional allows existing code that implements this interface to not break. Fixes: #880
While it's always present (even if null), having it optional allows existing code that implements this interface to not break. Fixes: #880
Are you going to release a bug fix update? |
@mrgrauel |
[READ] Step 1: Are you in the right place?
👍
[REQUIRED] Step 2: Describe your environment
[REQUIRED] Step 3: Describe the problem
When upgrading to
8.12
from8.11
my build failed with:The relevant line in firebase-functions is here:
https://github.com/firebase/firebase-functions/blob/87e75d717d5acf32d893e867078c531542d30c69/src/providers/auth.ts#L55
It seems that
lastRefreshTime
was added here:#726
Maybe it should be optional not
string | null
Steps to reproduce:
firebase/snippets-node#105
Relevant Code:
The text was updated successfully, but these errors were encountered: