Allow Credential to auto-generate typings, separate internal vs external APIs #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
suggested changes
Aug 25, 2020
hiranya911
suggested changes
Aug 26, 2020
| @@ -19,7 +19,7 @@ import fs = require('fs'); | |||
| import os = require('os'); | |||
| import path = require('path'); | |||
|
|
|||
| import { GoogleOAuthAccessToken, Credential } from './credential'; | |||
| import { GoogleOAuthAccessToken, Credential } from './google-oauth-access-token'; | |||
There was a problem hiding this comment.
Lets call it credential-interfaces.ts since it has more than just the access token type.
src/credential/index.ts
Outdated
| @@ -15,6 +15,7 @@ | |||
| */ | |||
|
|
|||
| import * as credentialApi from './credential'; | |||
| import * as googleOauthAccessTokenApi from './google-oauth-access-token'; | |||
There was a problem hiding this comment.
GoogleOAuthAccessToken interface should also be exported. But looks like it's part of the admin namespace today. So perhaps we should do it later once we start refactoring the top-level admin namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
Credentialto auto-generate typings and separate internal vs external APIs.Follow-up to #1011.