Skip to content

fix(storage): Support typing generation for the storage API #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2020
Merged

fix(storage): Support typing generation for the storage API #1019

merged 3 commits into from
Sep 3, 2020

Conversation

hiranya911
Copy link
Contributor

Continuing the work started by @MathBunny, this PR adds support for auto-generating typings for the Storage APIs:

  • Moved existing admin.storage typings into a new src/storage.d.ts file, so they can be easily screened out during typing auto-generation.
  • Added src/storage/index.ts file with the barrel exports.
  • Updated the gulpfile to auto-generate typings for Storage.

@hiranya911 hiranya911 added the release:stage Stage a release candidate label Sep 3, 2020
lahirumaramba
lahirumaramba approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!
LGTM!

@hiranya911 hiranya911 merged commit f11aed7 into master Sep 3, 2020
@hiranya911 hiranya911 deleted the hkj-storage-typegen branch September 3, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@hiranya911 hiranya911

Labels
release:stage Stage a release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiranya911 @lahirumaramba