Skip to content

chore(auth): Exposed admin.auth namespace #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 5, 2020
Merged

chore(auth): Exposed admin.auth namespace #1053

merged 4 commits into from
Oct 5, 2020

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Oct 1, 2020 •
edited
Loading

  • Exposed admin.auth namespace and the App.auth() method.
  • The public SAMLAuthProviderConfig doesn't support enableRequestSigning although the implementation does. Needed some minor changes in the implementation and the tests to reconcile this.
  • TenantOptions type only exists in the implementation. In the public API this is UpdateTenantRequest. Needed some changes to reconcile this.

Part of the go/firebase-node-one-source effort.

lahirumaramba
lahirumaramba approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lahirumaramba lahirumaramba removed their assignment Oct 2, 2020
bojeil-google
bojeil-google approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of nits/questions.

test/unit/auth/auth-api-request.spec.ts Outdated
@@ -4448,7 +4453,7 @@ AUTH_REQUEST_HANDLER_TESTS.forEach((handler) => {
describe('createTenant', () => {
const path = '/v2/projects/project_id/tenants';
const postMethod = 'POST';
const tenantOptions: TenantOptions = {
const tenantOptions: UpdateTenantRequest = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be CreateTenantRequest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

test/unit/auth/tenant-manager.spec.ts Outdated
@@ -25,9 +25,13 @@ import * as chaiAsPromised from 'chai-as-promised';
import * as mocks from '../../resources/mocks';
import { FirebaseApp } from '../../../src/firebase-app';
import { AuthRequestHandler } from '../../../src/auth/auth-api-request';
import { Tenant, TenantOptions, TenantServerResponse, ListTenantsResult } from '../../../src/auth/tenant';
import { Tenant, TenantServerResponse } from '../../../src/auth/tenant';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

test/unit/auth/tenant-manager.spec.ts Outdated
@@ -377,7 +381,7 @@ describe('TenantManager', () => {
});

describe('createTenant()', () => {
const tenantOptions: TenantOptions = {
const tenantOptions: UpdateTenantRequest = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: CreateTenantRequest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

test/unit/auth/tenant.spec.ts Outdated
@@ -181,7 +180,7 @@ describe('Tenant', () => {

describe('for a create request', () => {
it('should return the expected server request without multi-factor and phone config', () => {
const tenantOptionsClientRequest: TenantOptions = deepCopy(clientRequestWithoutMfa);
const tenantOptionsClientRequest: UpdateTenantRequest = deepCopy(clientRequestWithoutMfa);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be CreateTenantRequest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hiranya911 hiranya911 merged commit 8e08c5e into typegen Oct 5, 2020
@hiranya911 hiranya911 deleted the hkj-auth branch October 5, 2020 19:30
hiranya911 added a commit that referenced this pull request Nov 2, 2020
@hiranya911
chore: Auto-generating typings from the source (#1072)
5d72c1b 
* chore: Removing ambient typing files (#1032)

* chore: Removing ambient typing files

* chore: Added some TODOs to keep track of WIP

* chore: Added the credentials API signatures and exposed admin.credential (#1035)

* chore: Added the credentials API signatures and exposed admin.credential

* fix: Updated ServiceAccountCredential constructor signature

* chore: Declared admin and admin.app namespaces (#1037)

* chore: Added some TODOs to keep track of WIP

* chore: Declared admin and admin.app namespaces

* fix: Fixing an indentation issue

* fix(rc): Exposed admin.remoteConfig namespace (#1038)

* fix(fcm): Exposed admin.messaging namespace (#1039)

* chore(iid): Exposed admin.instanceId namespace (#1046)

* chore(iid): Exposed admin.instanceId namespace

* fix: Fixing some bad indentation in comments

* chore(rtdb): Exposed admin.database namespace (#1043)

* chore(rules): Exposed admin.securiryRules namespace (#1050)

* chore: Exposed admin.projectManagement namespace (#1054)

* chore(auth): Exposed admin.auth namespace (#1053)

* chore(auth): Exposed admin.auth namespace

* fix(auth): Fixing unit tests for SAMLConfig

* fix(auth): Removing more auth. prefixed direct references

* fix(auth): Using CreateTenantRequest explicitly where appropriate

* chore(ml): Exposed admin.machineLearning namespace (#1055)

* chore(ml): Exposed admin.machineLearning namespace

* fix(ml): Fixing some code formatting issues

* chore: Exposed admin.storage and admin.firestore namespaces (#1056)

* chore(ml): Exposed admin.machineLearning namespace

* chore: Exposed admin.firestore and admin.storage namespaces

* chore: Merged with upstream; Re-enabled build:tests CI task

* chore: Using public API types in FirebaseNamespace impl (#1057)

* chore: Updated TypeDoc workflow to generate API docs (#1060)

* chore: Experimental typedoc pipeline for doc generation

* chore: Adding RTDB type aliases to the API docs

* Updated comments

* Cleaned up the docgen script; Fixed a file name check warning

* fix: Fixed cross links; Fixed a faulty regex replacement in links

* fix: Fixing the remaining cross linkage errors

* chore: Enabled quotes rule in eslint config (#1067)

* chore: Enabled quotes rule in esline config

* fix: Enabled avoidEscape option

* fix: Fixed a typo in an error message
BorntraegerMarc pushed a commit to BorntraegerMarc/firebase-admin-node that referenced this pull request Jan 28, 2021
@hiranya911 @BorntraegerMarc
chore: Auto-generating typings from the source (firebase#1072)
af6f08b 
* chore: Removing ambient typing files (firebase#1032)

* chore: Removing ambient typing files

* chore: Added some TODOs to keep track of WIP

* chore: Added the credentials API signatures and exposed admin.credential (firebase#1035)

* chore: Added the credentials API signatures and exposed admin.credential

* fix: Updated ServiceAccountCredential constructor signature

* chore: Declared admin and admin.app namespaces (firebase#1037)

* chore: Added some TODOs to keep track of WIP

* chore: Declared admin and admin.app namespaces

* fix: Fixing an indentation issue

* fix(rc): Exposed admin.remoteConfig namespace (firebase#1038)

* fix(fcm): Exposed admin.messaging namespace (firebase#1039)

* chore(iid): Exposed admin.instanceId namespace (firebase#1046)

* chore(iid): Exposed admin.instanceId namespace

* fix: Fixing some bad indentation in comments

* chore(rtdb): Exposed admin.database namespace (firebase#1043)

* chore(rules): Exposed admin.securiryRules namespace (firebase#1050)

* chore: Exposed admin.projectManagement namespace (firebase#1054)

* chore(auth): Exposed admin.auth namespace (firebase#1053)

* chore(auth): Exposed admin.auth namespace

* fix(auth): Fixing unit tests for SAMLConfig

* fix(auth): Removing more auth. prefixed direct references

* fix(auth): Using CreateTenantRequest explicitly where appropriate

* chore(ml): Exposed admin.machineLearning namespace (firebase#1055)

* chore(ml): Exposed admin.machineLearning namespace

* fix(ml): Fixing some code formatting issues

* chore: Exposed admin.storage and admin.firestore namespaces (firebase#1056)

* chore(ml): Exposed admin.machineLearning namespace

* chore: Exposed admin.firestore and admin.storage namespaces

* chore: Merged with upstream; Re-enabled build:tests CI task

* chore: Using public API types in FirebaseNamespace impl (firebase#1057)

* chore: Updated TypeDoc workflow to generate API docs (firebase#1060)

* chore: Experimental typedoc pipeline for doc generation

* chore: Adding RTDB type aliases to the API docs

* Updated comments

* Cleaned up the docgen script; Fixed a file name check warning

* fix: Fixed cross links; Fixed a faulty regex replacement in links

* fix: Fixing the remaining cross linkage errors

* chore: Enabled quotes rule in eslint config (firebase#1067)

* chore: Enabled quotes rule in esline config

* fix: Enabled avoidEscape option

* fix: Fixed a typo in an error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@bojeil-google bojeil-google bojeil-google approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiranya911 @lahirumaramba @bojeil-google