Skip to content

fix: Adding es2018 libraries to the build #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2020
Merged

fix: Adding es2018 libraries to the build #1079

merged 1 commit into from
Nov 2, 2020

Conversation

hiranya911
Copy link
Contributor

Latest versions of GCP dependencies like Firestore require es2018 libraries included in the tsc build. This helps avoid build errors like https://github.com/firebase/firebase-admin-node/actions/runs/342357542

@hiranya911 hiranya911 added the release:stage Stage a release candidate label Nov 2, 2020
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@hiranya911 hiranya911 merged commit b5606aa into master Nov 2, 2020
@hiranya911 hiranya911 deleted the hkj-es2018 branch November 2, 2020 22:12
BorntraegerMarc pushed a commit to BorntraegerMarc/firebase-admin-node that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants